sharpetronics/faraday
1
0
Fork 0
mirror of https://github.com/lostisland/faraday.git synced 2025-08-30 00:03:09 -04:00
Code Issues Projects Releases Wiki Activity

Unescape basic authentication username and password when pulling them from a URL.

Browse Source
This commit is contained in:
Mike Heffner 2011-10-12 12:54:41 -04:00
parent a919c4d177
commit 5a4468bc25
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/faraday/connection.rb
View File

@ -177,7 +177,9 @@ module Faraday
self.path_prefix = uri.path
@params.merge_query(uri.query)
basic_auth(uri.user, uri.password) if uri.user && uri.password
if uri.user && uri.password
basic_auth(CGI.unescape(uri.user), CGI.unescape(uri.password))
end
uri
end

5
test/connection_test.rb
View File

@ -73,6 +73,11 @@ class TestConnection < Faraday::TestCase
assert_equal 'Basic YWxhZGRpbjpvcGVuc2VzYW1l', conn.headers['Authorization']
end
def test_auto_parses_basic_auth_from_url_and_unescapes
conn = Faraday::Connection.new :url => "http://foo%40bar.com:pass%20word@sushi.com/fish"
assert_equal 'Basic Zm9vQGJhci5jb206cGFzcyB3b3Jk', conn.headers['Authorization']
end
def test_token_auth_sets_authorization_header
conn = Faraday::Connection.new
conn.token_auth 'abcdef'