sharpetronics/faraday
1
0
Fork 0
mirror of https://github.com/lostisland/faraday.git synced 2025-10-17 00:05:28 -04:00
Code Issues Projects Releases Wiki Activity

Duplicate SSL settings on #dup call

Browse Source
This commit is contained in:
Saulius Grigaliunas 2011-07-28 11:49:46 +03:00
parent 194f06be24
commit 29bfde444b
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/faraday/connection.rb
View File

@ -237,7 +237,7 @@ module Faraday
end end
def dup def dup
self.class.new(build_url(''), :headers => headers.dup, :params => params.dup, :builder => builder.dup) self.class.new(build_url(''), :headers => headers.dup, :params => params.dup, :builder => builder.dup, :ssl => ssl.dup)
end end
def proxy_arg_to_uri(arg) def proxy_arg_to_uri(arg)

5
test/connection_test.rb
View File

@ -238,15 +238,16 @@ class TestConnection < Faraday::TestCase
end end
def test_dups_connection_object def test_dups_connection_object
conn = Faraday::Connection.new 'http://sushi.com/foo' do |b| conn = Faraday::Connection.new 'http://sushi.com/foo', :ssl => { :verify => :none } do |b|
b.adapter :net_http b.adapter :net_http
end end
conn.headers['content-type'] = 'text/plain' conn.headers['content-type'] = 'text/plain'
conn.params['a'] = '1' conn.params['a'] = '1'
duped = conn.dup duped = conn.dup
assert_equal conn.build_url(''), duped.build_url('') assert_equal conn.build_url(''), duped.build_url('')
[:headers, :params, :builder].each do |attr| [:headers, :params, :builder, :ssl].each do |attr|
assert_equal conn.send(attr), duped.send(attr) assert_equal conn.send(attr), duped.send(attr)
assert_not_equal conn.send(attr).object_id, duped.send(attr).object_id assert_not_equal conn.send(attr).object_id, duped.send(attr).object_id
end end