sharpetronics/crunchbutton
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fixed #647

Browse Source 
There is a JS problem when doing float sums, solved multiplying the breakdown for 100 before the sum
This commit is contained in:
Stuardo Rodríguez 2013-01-17 15:14:50 -05:00
parent 438f4aef8c
commit 564ec839c0
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
www/assets/js/app.js
View File

@ -1301,6 +1301,13 @@ App.cart = {
return tip; return tip;
}, },
/**
* Sums the breakdown and returns formated number
*
* Because of the JS math problem we can't sum decimals, let's multiply it all by 100
*
* @return string
*/
total: function() { total: function() {
var var
total = 0, total = 0,
@ -1311,15 +1318,21 @@ App.cart = {
finalAmount = 0 finalAmount = 0
; ;
var breakdown = this.totalbreakdown(); var breakdown = this.totalbreakdown() ;
// Because of the JS math problem we can't sum decimals, let's multiply it all by 100
for (i in breakdown) {
breakdown[i] *= 100;
}
total = breakdown.subtotal; total = breakdown.subtotal;
feeTotal = total; feeTotal = total;
feeTotal += breakdown.delivery; feeTotal += breakdown.delivery;
feeTotal += breakdown.fee; feeTotal += breakdown.fee;
finalAmount = feeTotal + breakdown.taxes; finalAmount = feeTotal + breakdown.taxes;
finalAmount += this._breakdownTip(total); finalAmount += breakdown.tip;
finalAmount /=100; // return it to decimals
finalAmount = App.ceil(finalAmount).toFixed(2);
return App.ceil(finalAmount).toFixed(2); return finalAmount;
}, },
/** /**
@ -1341,7 +1354,6 @@ App.cart = {
feeTotal += elements['fee']; feeTotal += elements['fee'];
elements['taxes'] = this._breackDownTaxes(feeTotal); elements['taxes'] = this._breackDownTaxes(feeTotal);
elements['tip'] = this._breakdownTip(total); elements['tip'] = this._breakdownTip(total);
console.log(elements);
return elements; return elements;
}, },