From 9f83bb31a12a771f0395922c9993f7a4654a0e53 Mon Sep 17 00:00:00 2001 From: Roberto Guido Date: Mon, 10 Mar 2025 16:37:32 +0100 Subject: [PATCH 1/3] Coherent default for focus box in select `$form-select-focus-box-shadow` doesn't fallback on common settings about focus boxes, and has a different behavior when applying settings descripted [in the documentation](https://getbootstrap.com/docs/5.3/helpers/focus-ring/#sass-variables) (just setting `$focus-ring-box-shadow` does not impact on select boxes). --- scss/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index a55411a53a..e3295f540f 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -1025,7 +1025,7 @@ $form-select-box-shadow: var(--#{$prefix}box-shadow-inset) !default; $form-select-focus-border-color: $input-focus-border-color !default; $form-select-focus-width: $input-focus-width !default; -$form-select-focus-box-shadow: 0 0 0 $form-select-focus-width $input-btn-focus-color !default; +$form-select-focus-box-shadow: $input-focus-box-shadow !default; $form-select-padding-y-sm: $input-padding-y-sm !default; $form-select-padding-x-sm: $input-padding-x-sm !default; From 0049a71f8a52fac1f80e463ef8e6bec3f640c946 Mon Sep 17 00:00:00 2001 From: Roberto Guido Date: Mon, 7 Apr 2025 01:05:19 +0200 Subject: [PATCH 2/3] Removed unused variables --- scss/_variables.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index e3295f540f..90ea1dd3dd 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -794,7 +794,6 @@ $input-btn-line-height: $line-height-base !default; $input-btn-focus-width: $focus-ring-width !default; $input-btn-focus-color-opacity: $focus-ring-opacity !default; -$input-btn-focus-color: $focus-ring-color !default; $input-btn-focus-blur: $focus-ring-blur !default; $input-btn-focus-box-shadow: $focus-ring-box-shadow !default; @@ -1024,7 +1023,6 @@ $form-select-border-radius: $input-border-radius !default; $form-select-box-shadow: var(--#{$prefix}box-shadow-inset) !default; $form-select-focus-border-color: $input-focus-border-color !default; -$form-select-focus-width: $input-focus-width !default; $form-select-focus-box-shadow: $input-focus-box-shadow !default; $form-select-padding-y-sm: $input-padding-y-sm !default; From 173acfd0646e04b70a5885ef3ae2feb1e4d857da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20D=C3=A9ramond?= Date: Mon, 7 Apr 2025 21:00:47 +0200 Subject: [PATCH 3/3] Deprecating Sass variables instead of removing them --- scss/_variables.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scss/_variables.scss b/scss/_variables.scss index 90ea1dd3dd..048d56b07f 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -794,6 +794,9 @@ $input-btn-line-height: $line-height-base !default; $input-btn-focus-width: $focus-ring-width !default; $input-btn-focus-color-opacity: $focus-ring-opacity !default; +// fusv-disable +$input-btn-focus-color: $focus-ring-color !default; // Deprecated in v5.4.0 +// fusv-enable $input-btn-focus-blur: $focus-ring-blur !default; $input-btn-focus-box-shadow: $focus-ring-box-shadow !default; @@ -1023,6 +1026,9 @@ $form-select-border-radius: $input-border-radius !default; $form-select-box-shadow: var(--#{$prefix}box-shadow-inset) !default; $form-select-focus-border-color: $input-focus-border-color !default; +// fusv-disable +$form-select-focus-width: $input-focus-width !default; // Deprecated in v5.4.0 +// fusv-enable $form-select-focus-box-shadow: $input-focus-box-shadow !default; $form-select-padding-y-sm: $input-padding-y-sm !default;