mirror of
https://github.com/qgis/QGIS.git
synced 2025-02-23 00:02:38 -05:00
ce8cd3d551
At the moment the clang-tidy CI fails on each file with the following message: ``` error: PCH file uses an older PCH format that is no longer supported [clang-diagnostic-error] ``` This is because clang-tidy version 18 is used while QGIS compilation is achieved with clang 15. Indeed, QGIS is built with clazy support which relies on clang 15. This issue is fixed by using clang version 15 instead of version 18 in `docker-qgis-clangtidy.sh`.
55 lines
2.5 KiB
Bash
Executable File
55 lines
2.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
###########################################################################
|
|
# docker-qgis-clangtidy.sh
|
|
# ---------------------
|
|
# Date : September 2022
|
|
# Copyright : (C) 2022 by Julien Cabieces
|
|
# Email : julien dot cabieces at oslandia dot com
|
|
###########################################################################
|
|
# #
|
|
# This program is free software; you can redistribute it and/or modify #
|
|
# it under the terms of the GNU General Public License as published by #
|
|
# the Free Software Foundation; either version 2 of the License, or #
|
|
# (at your option) any later version. #
|
|
# #
|
|
###########################################################################
|
|
|
|
set -e
|
|
|
|
SRCDIR=${CTEST_SOURCE_DIR-/root/QGIS}
|
|
cd ${SRCDIR}
|
|
|
|
# This is needed for `git status` to work, see
|
|
# https://github.com/qgis/QGIS/runs/6733585841?check_suite_focus=true#step:13:89
|
|
git config --global --add safe.directory ${SRCDIR}
|
|
|
|
# The clang-tidy version installed needs to match the one used to compile QGIS.
|
|
# Otherwise, it will not be able to inspect the modified files.
|
|
echo "::group::Install clang tidy"
|
|
apt install -y \
|
|
clang-tidy-15
|
|
echo "::endgroup::"
|
|
|
|
cd ${SRCDIR}
|
|
|
|
echo "::group::Download clang-tidy-diff"
|
|
curl -XGET https://raw.githubusercontent.com/llvm/llvm-project/llvmorg-15.0.7/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py -o clang-tidy-diff.py
|
|
echo "::endgroup::"
|
|
|
|
echo "${bold}Disable unity build...${endbold}"
|
|
cmake . -B build -DENABLE_UNITY_BUILDS=OFF
|
|
|
|
echo "${bold}Run clang-tidy on modifications...${endbold}"
|
|
|
|
# We need to add build/src/test dir as extra include directories because when clang-tidy tries to process qgstest.h
|
|
# it has no compile_commands.json instructions to know what are include directories
|
|
# It manages to figure out for other headers though, I don't get how...
|
|
git diff -U0 HEAD^ | python3 clang-tidy-diff.py -p1 -path=${CTEST_BUILD_DIR} -use-color -extra-arg=-I${CTEST_BUILD_DIR}/src/test/ -clang-tidy-binary /usr/bin/clang-tidy-15 | tee clang-tidy.log
|
|
|
|
echo -e "\e[1;34mTo reproduce locally:"
|
|
echo -e "\e[1;34m - launch cmake with option -DCMAKE_EXPORT_COMPILE_COMMANDS=ON"
|
|
echo -e "\e[1;34m - update build by calling Ninja"
|
|
echo -e "\e[1;34m - launch command ./scripts/clang-tidy.sh -p <your_build_dir> <source_file>"
|
|
|
|
exit $(grep -c "warning:" clang-tidy.log)
|