Merge 4bf89cb099116ed5368ccdd04937eb0dcd848482 into d63653925c5c55cf16618e5ed16fb71f0c9620dc

Don't add undo step when algorithm was not modified
2025-10-03 00:04:47 -04:00 · 2025-10-01 02:56:41 +02:00 · 2025-09-05 22:39:06 +03:00
1 changed files with 17 additions and 1 deletions
--- a/python/plugins/processing/modeler/ModelerParametersDialog.py
+++ b/python/plugins/processing/modeler/ModelerParametersDialog.py
@ -195,8 +195,24 @@ class ModelerParametersDialog(QDialog):
        return self.widget.createAlgorithm()

    def okPressed(self):
-        if self.createAlgorithm() is not None:
+        alg = self.createAlgorithm()
+        if alg is None:
+            return
+
+        try:
+            modelAlg = self.model.childAlgorithms()[alg.childId()]
+        except KeyError:
+            # Algorithm is being added to the model, just accept it
            self.accept()
+            return
+        else:
+            # Algorithm is being modified, match the non-definition properties and then check for changes
+            alg.copyNonDefinitionProperties(modelAlg)
+            if modelAlg.toVariant() != alg.toVariant():
+                self.accept()
+                return
+        # No changes were made to the algorithm, treat as 'Cancel' to prevent unnecessary undo steps
+        self.reject()

    def openHelp(self):
        algHelp = self.widget.algorithm().helpUrl()
Author	SHA1	Message	Date
Stefanos Natsis	9456939cb7	Merge 4bf89cb099116ed5368ccdd04937eb0dcd848482 into d63653925c5c55cf16618e5ed16fb71f0c9620dc	2025-10-01 02:56:41 +02:00
uclaros	4bf89cb099	Don't add undo step when algorithm was not modified	2025-09-05 22:39:06 +03:00