Custom utils._import was never called, because
builtins was correctly imported (even if it missed __import__)
and _import was then monkey patched to builtins instead of __builtin__
Tested on python 2
If an iterator fails to open the spatialite database (mHandle == nullptr
in QgsSpatiaLiteFeatureIterator::QgsSpatiaLiteFeatureIterator() ),
a crash will occur at the destruction of the QgsSpatiaLiteFeatureSource,
due to the iterator not being removed from the list of active iterators.
Currently QgsSpatiaLiteFeatureIterator::close() does not call
iteratorClosed() if mHandle is invalid, which later causes
QgsAbstractFeatureSource::~QgsAbstractFeatureSource() to try calling
the close() method of a now defunct iterator.
If not applying the patch, the added test case crashes with:
177: src/providers/spatialite/qgsspatialiteconnection.cpp: 736: (openDb) [1ms] New sqlite connection for /tmp/test.sqlite.corrupt
177: src/providers/spatialite/qgsspatialiteconnection.cpp: 750: (openDb) [1ms] Failure while connecting to: /tmp/test.sqlite.corrupt
177:
177: invalid metadata tables
177: src/core/qgsfeaturerequest.cpp: 259: (~QgsAbstractFeatureSource) [0ms] closing active iterator
177: CMake Error at PyQgsSpatialiteProvider.cmake:22 (MESSAGE):
177: Test failed: Segmentation fault
Currently there's an inconsistancy between the Options dialog that displays a
default value of 60000ms for network request timeouts, whereas places in the
code use 20000ms. I propose to align on 60000s, since there are occurrences
of network requests, for example big WFS GetFeature requests, that can take
more than 20s to start.
Currently sqlite3_bind_blob() uses free() as the free function of WKB
blobs returned by convertFromGeosWKB(). But those are allocated with
new[] and should consequently be freed with delete[].
Spotted by Valgrind:
==4014== Mismatched free() / delete / delete []
==4014== at 0x4C287BE: free (vg_replace_malloc.c:446)
==4014== by 0xE42E481: sqlite3VdbeMemReleaseExternal (sqlite3.c:57237)
==4014== by 0xE42E4E3: sqlite3VdbeMemRelease (sqlite3.c:57252)
==4014== by 0xE42EC3E: releaseMemArray (sqlite3.c:59208)
==4014== by 0xE42ED1E: sqlite3VdbeDeleteObject (sqlite3.c:60561)
==4014== by 0xE46A6DB: sqlite3VdbeFinalize (sqlite3.c:60528)
==4014== by 0xE46A916: sqlite3_finalize (sqlite3.c:61431)
==4014== by 0x7FB23958: QgsSpatiaLiteProvider::addFeatures(QList<QgsFeature>&) (qgsspatialiteprovider.cpp:3752)
==4014== Address 0x8e2a8b30 is 0 bytes inside a block of size 94 alloc'd
==4014== at 0x4C29520: operator new[](unsigned long) (vg_replace_malloc.c:363)
==4014== by 0x7FB1B964: QgsSpatiaLiteProvider::convertFromGeosWKB(unsigned char const*, int, unsigned char**, int*, int) (qgsspatialiteprovider.cpp:1341)
==4014== by 0x7FB234B5: QgsSpatiaLiteProvider::addFeatures(QList<QgsFeature>&) (qgsspatialiteprovider.cpp:3676)
[processing] fix filter in Processing settings dialog. Add ability to specify mininal required number of items for MultipleInput parameter (fix#11469, fix#12580)
* drop libpasteurize.fixes.fix_division
* replace lib2to3.fixes.fix_import with libfuturize.fixes.fix_absolute_import (with PyQt exclude plus AlgorithmsTestBase)
* drop lib2to3.fixes.fix_print (replaced with libfuturize.fixes.fix_print_with_import)
