14266 Commits

Author SHA1 Message Date
Nyall Dawson
39d148612b Optimise conversion of geometry from OGR -> QGIS
Avoid conversion to/from WKB at OGR/QGIS side, and just directly
utilise OGR geometry API to construct QGIS geometries.

Shaves ~10% off rendering time for a large point layer (GPKG)
2018-09-28 13:17:12 +10:00
Harrissou Sant-anna
b478ee750c Fix "Array of offset lines" algorithm 2018-09-28 10:19:31 +10:00
Harrissou Sant-anna
9e5cc4b76b Fix array of translated features algorithms 2018-09-28 10:19:31 +10:00
rldhont
c15f05b4c9 [Bugfix][Server] Add WMS SLD parameter support
Fixed #19795 QGIS Server 3 / WMS: the SLD parameter support has been removed

To reactivate SLD parameter support, we add a new conversion capability in server parameter `toUrl`. And the capabilty to load the content associted to an URL.

Then if the SLD parameter is defined, the content is loaded and the SLD_BODY is set.
2018-09-27 21:08:33 +02:00
Alessandro Pasotti
c06c475b9c [db-manager] Update sql dialog buttons status
Fixes #19958 - Database manager allows one to create saved query with no name
2018-09-27 08:29:27 +02:00
Alessandro Pasotti
94ded32f4e [db-manager] Allow multiline filters in sql window
Fixes #19956 - Update SQL layer results in invalid SQL expression
2018-09-27 08:01:40 +02:00
Martin Dobias
a1d130ac97 Fix spelling 2018-09-27 00:46:37 +02:00
Martin Dobias
8831f19b79 Fix missing indicators after they are moved to a different group
The issue was that during drag&drop, we first connect to layer's signal
for the second time, but then the disconnect() call on removal of the original
layer node would disconnect all connections (not just one). For that reason
now we only connect/disconnect when the layer is in the tree only once.
2018-09-27 00:46:37 +02:00
Matthias Kuhn
c3066c2c46
Cleanup 2018-09-26 19:47:26 +02:00
Matthias Kuhn
0e3280768c
Change canCommitChanges to allowCommit flag 2018-09-26 18:31:03 +02:00
Matthias Kuhn
cda4950dd8
Change canCommitChanges to allowCommit flag 2018-09-26 17:35:53 +02:00
Matthias Kuhn
d2bb3d606b
Fix python signature? 2018-09-26 17:15:53 +02:00
Matthias Kuhn
a56deacf54
Add QgsVectorLayer::canCommitChanges
to control if changes can be saved or not. This signal is emitted before a layer is being saved and if a connected slot marks the canCommit variable as False, the layer will not be saved
2018-09-26 16:17:24 +02:00
Alessandro Pasotti
51574069a0 Fixes blocking if the edit in place functionality is used in the locator bar (with ef) on an non-modifiable layer
Fixes #19950
2018-09-26 14:19:58 +02:00
Martin Dobias
5047571c13 Move recursive "collect layers" algorithm to QgsLayerTreeUtils + tests 2018-09-26 09:55:37 +02:00
Martin Dobias
ea1716261a Make sure that also groups with "required" layers cannot be removed
Fixes an unreported bug where it was possible to select a layer tree group
and remove even when it contained required layers.

When removing layers/groups, the following checks will now also recursively
test layers and not just directly selected layers:
- test for layers with unsaved changes
- test for layers with active tasks running in background
2018-09-26 09:55:37 +02:00
Alessandro Pasotti
6aa00b14f3
Merge pull request #8022 from elpaso/bugfix-19831-db-manager-import-srid
[dbmanager] Fixes DB Manager does not read SRID automatically
2018-09-26 08:49:32 +02:00
Nyall Dawson
6e03253143 [processing][gdal] Fix empty fid is passed if FID option is not set
Also add full range of unit tests for OgrToPostGis algorithm.

Fixes #19947
2018-09-26 08:07:09 +10:00
Nyall Dawson
0f62685963 Fix is_layer_visible to allow direct layer objects and handle removed layers 2018-09-26 04:27:27 +10:00
Nyall Dawson
f29c48b99b Dox 2018-09-26 04:27:08 +10:00
Nyall Dawson
fd1d6c1037 Add more descriptive error messages for raster calculation failure
With unit tests
2018-09-26 04:27:08 +10:00
Nyall Dawson
f4bbb147b2 Dox++ 2018-09-26 04:27:08 +10:00
Nyall Dawson
d26f25cf94 Deprecate unused QgsProcessingAlgorithm::helpString method 2018-09-26 04:26:49 +10:00
Nyall Dawson
844a3fb1b1 [processing] Allow help url to be set for models within help edit dialog
Refs #18767
2018-09-26 04:26:49 +10:00
Nyall Dawson
95d68e9172 [processing] Default to hiding help button for algorithms
And require that showing help is opt-in. Apart from a handful
of built-in providers, most providers will not have help pages
available within the QGIS documentation (including model and
script algorithms). Accordingly, we should hide the help button
by default and only show it for these selected providers.

Note that 3rd party algorithms can still specify custom helpUrl
urls, in which case the button WILL be shown.
2018-09-26 04:26:49 +10:00
Nyall Dawson
e2082a0935 [processing] Fix modeler help/description generation, allow setting
of model short description text

Fixes #18767
2018-09-26 04:26:49 +10:00
Nyall Dawson
aa55de8ef4 Fix advanced parameter panel incorrect margins in processing algorithm dialog 2018-09-26 04:26:27 +10:00
Nyall Dawson
6d1a9295f7 Use correct stylesheet for processing dialogs 2018-09-26 04:26:27 +10:00
Alessandro Pasotti
f7f70bfb03 [dbmanager] Fixes DB Manager does not read SRID automatically
Fixes #19831
2018-09-25 14:50:41 +02:00
Nyall Dawson
517b50c66d Capitalization 2018-09-25 22:01:39 +10:00
Loïc Bartoletti
9bbabcfbf5 Add test
Add onStyleChanged
Add if mRenderContext when necessary
Orderer renderer if and add enableInvisibleFeature
2018-09-25 13:09:11 +02:00
Alessandro Pasotti
b34c461dc1 Drop const on makeFeatureComptible returned values 2018-09-25 08:24:49 +02:00
Alessandro Pasotti
a8dbb5395c Some minor changes
- QgsVectorLayer *
- make a const copy of a const container
- typo and comments
2018-09-25 08:17:14 +02:00
Alessandro Pasotti
8d82ce86cc makeFeatureCompatible on a single input feature 2018-09-25 08:17:14 +02:00
Alessandro Pasotti
7e8592bca2 Const correctness (because it's not an API break) 2018-09-25 08:17:14 +02:00
Alessandro Pasotti
3157af2eaa Revert const on createFeature
just because it would be an API break
2018-09-25 08:17:14 +02:00
Alessandro Pasotti
930c3f8e45 Port makeFeaturesCompatible to C++
as: QgsVectorLayerUtils::makeFeaturesCompatible

With tests.
2018-09-25 08:17:14 +02:00
Nyall Dawson
af4a1df90d [browser] Correctly show drives inserted (or removed!) after QGIS launch
Fixes #14481, #9843
2018-09-25 13:22:01 +10:00
Nyall Dawson
c817e38be2 [processing] Fix an exception in modeler when editing a model in
which a child algorithm later has a new parameter added
2018-09-25 12:48:26 +10:00
Nyall Dawson
11991c5297 Fix capitalization 2018-09-25 12:41:12 +10:00
Nyall Dawson
ea2c16dd64 [processing][gdal] Dissolve field name should be optional 2018-09-25 11:14:33 +10:00
Nyall Dawson
a3af1f9f3a [processing][gdal] Add unit tests for Dissolve algorithm
Also:

Thanks to @agiudiceandrea:

Fixes #19900
Statistics were erroneously computed on the dissolve field, rather than on the statistic attribute field as it should be.

Fixes #19307
Handle filenames with white spaces (in the same way as Buffer, OffsetCurve, OneSideBuffer, PintsAlongLines algs).
2018-09-25 11:14:33 +10:00
Nyall Dawson
6e06c32a10 [processing] Fix crash when an algorithm dialog is left open and
processing options are changed

Make sure the algorithm dialogs use their own copy of algorithms,
instead of the copies owned by the processing registry. Opening
processing options triggers a full reload of providers, deleting
all existing algorithm instances from the registry first.
2018-09-25 10:32:20 +10:00
Nyall Dawson
c2dab4ff18 [processing] Use standard dock margins for results dock 2018-09-25 10:31:15 +10:00
Nyall Dawson
eacf4adb30 Dox++ 2018-09-25 08:49:21 +10:00
Nyall Dawson
9fcd4fd00c Use QgsVectorLayerUtils.matchAttributesToFields in processing in-place edits 2018-09-25 08:49:21 +10:00
Nyall Dawson
a8794001e0 Add method to match feature attributes to the given fields
Refs #18784
2018-09-25 08:49:21 +10:00
Loïc Bartoletti
458fa1752d Bette naming for python 2018-09-24 22:19:51 +02:00
Nyall Dawson
81487f9f18 Proxy filterNeedsGeometry for inverted/displacement renderers 2018-09-25 05:21:35 +10:00
Nyall Dawson
b5867bff58 Fix legend count is 0 if graduated/categorized expression uses geometry
Likely fixes many other bugs too with graduated/categorized renderers

Fixes #15544
2018-09-25 05:21:35 +10:00