40911 Commits

Author SHA1 Message Date
Nyall Dawson
aece517c50 Avoid duplicate geometry columns, invalid geometry column name in gdal points along lines alg 2017-08-15 20:58:08 +10:00
Nyall Dawson
3d1be95ad2 More comprehensive updating of gdal command when parameters change 2017-08-15 20:57:27 +10:00
Nyall Dawson
f88e62fb4a Unblacklist Processing GDAL test 2017-08-15 17:50:12 +10:00
Alessandro Pasotti
3922efcbc6 Merge pull request #5022 from boundlessgeo/gpkg-show-attributes
Geopackage fix mixed geometry layers and attributes
2017-08-15 08:20:40 +02:00
Alessandro Pasotti
7d074de90d Geopackage fix mixed geometry layers and attributes
In addition to geometry filtered layers for each geometry
type in a mixed-geometry type layer adds a table
layer with all attributes.

Tehre is no perfetc solution here, if the layer is created
with a filter on geometrytype, the attributes are not shown
(this is probably a pre-existing bug), if the layer is added
as is, only the first geometry type is drawn.

With this implementation at least all data (attributes and
geometries) are accessible in some way.

Note that geopackage layers added by DB Manager do not show
all geometries of a mixed type layer.
2017-08-14 20:25:47 +02:00
Alessandro Pasotti
7d4f81d4c6 Merge pull request #5019 from boundlessgeo/gpkg-dbmanager-sync
Geopackage: Use the same settings for DB Manager and browser
2017-08-14 16:42:38 +02:00
Matthias Kuhn
80e8ff04e0 Merge pull request #5014 from m-kuhn/enumgeomfunc
Return enum instead of int from QgsGeometry operations
2017-08-14 15:06:06 +02:00
Alessandro Pasotti
04f79d174d Geopackage: Use the same settings for DB Manager and browser 2017-08-14 15:04:54 +02:00
Alessandro Pasotti
904cd6f104 Merge pull request #5018 from boundlessgeo/gpkg-show-tables
Browser tree: also show geopackage geometryless layers as tables
2017-08-14 14:19:10 +02:00
arnaud.morvan@camptocamp.com
b26e6812d4 [processing] Check all parameter's values in ModelerParametersDialog
Check that all parameter's values pass the validity check,
even if not returned as QgsProcessingModelChildParameterSource.

In case of list, tests that it is really a QgsProcessingModelChildParameterSource list,
and create a QgsProcessingModelChildParameterSource from the list if it is not the case
(useful for custom parameters that return lists as ParameterFieldsMapping).
2017-08-14 13:48:50 +02:00
arnaud.morvan@camptocamp.com
b3a9e46cfe [processing] Port refactor fields to new API 2017-08-14 13:48:50 +02:00
Alessandro Pasotti
11f179154f Browser tree: also show geometryless layers as tables 2017-08-14 13:29:06 +02:00
Matthias Kuhn
3d53a2dfb8
Spelling 2017-08-14 13:11:13 +02:00
Matthias Kuhn
fca603caa3
Fix splitFeatures 2017-08-14 12:59:40 +02:00
Matthias Kuhn
cb29b2e6ef
Fix crash in test 2017-08-14 12:44:55 +02:00
Alessandro Pasotti
2364801634 Merge pull request #5016 from boundlessgeo/gpkg-handle-collections
Geopackage: proper handling of geometry ANY
2017-08-14 12:19:01 +02:00
Matthias Kuhn
0683528d9a
More doxymentation 2017-08-14 10:52:43 +02:00
Matthias Kuhn
a70bfe6ff8
More doxymentation 2017-08-14 10:43:37 +02:00
Alessandro Pasotti
ad2f760c0e GPKG: proper handling of unknown geometry
This handles the test use case for layer:
Layer name: geometry2d
Geometry: Unknown (any)
Feature Count: 8

The browser tree will now show the different geometry
layers and allow them to be added in the canvas,
GeometryCollections are skipped.
2017-08-14 10:39:57 +02:00
Matthias Kuhn
8294c434c6
More doxymentation 2017-08-14 10:37:51 +02:00
Matthias Kuhn
a4dac6ace2
Define params as /Out/ 2017-08-14 08:58:59 +02:00
Matthias Kuhn
f9ba9052b5
Fix segfault 2017-08-14 08:19:35 +02:00
Matthias Kuhn
0df873c505
Increase QgsGeometry::OperationResult values
To avoid collisions with old enums and make it easier for plugin devs to
determine if their values have already been ported to QGIS 3.0 or not.
2017-08-13 23:08:45 +02:00
Denis Rouzaud
86e8da74cb
Return enum instead of int from QgsGeometry operations 2017-08-13 23:08:45 +02:00
Nyall Dawson
8d615543b7 Merge pull request #4835 from nyalldawson/more_processing
[processing] Restore some gdal provider algorithms
2017-08-14 06:31:08 +10:00
Nyall Dawson
f9750dde52 Port gdal color relief to new API 2017-08-14 05:55:50 +10:00
Nyall Dawson
1cbbbc4b83 Port gdal tri alg to new API 2017-08-14 05:49:18 +10:00
Nyall Dawson
ab2886dc63 Port gdal assign projection to new api 2017-08-14 05:41:54 +10:00
Nyall Dawson
19e5886b87 More reliable updates to the gdal command shown
By also checking for child widget signals - otherwise we don't
catch signals when compound widgets (such as raster layer source
widgets) are changed
2017-08-14 05:41:00 +10:00
Nyall Dawson
95fe5cdc04 Fix errors calculating gdal command when dialog is being constructed 2017-08-14 05:24:59 +10:00
Nyall Dawson
ba6e2dc940 Fix showing gdal command in algorithm dialog 2017-08-14 05:19:29 +10:00
Nyall Dawson
3d3d2975a4 Followup fixes to ogr2ogrpostgis alg porting 2017-08-14 05:19:00 +10:00
Nyall Dawson
1cbbb8a0fb Port gdal aspect alg to new API 2017-08-14 05:05:39 +10:00
Nyall Dawson
2e7db48d20 Fix error in gdal warp algorithm 2017-08-14 04:56:36 +10:00
Nyall Dawson
b87b2fe827 Allow skipping crs check in processing test results
The GML format often requires extra 'hand holding' in order to
get QGIS to detect it's CRS (e.g. GML files created directly
in GDAL will not have an autodetected CRS when pulled into
QGIS). This needs fixing, but as a workaround to allow
processing algorithm porting to continue we can now skip
the crs check for these layers.
2017-08-14 04:56:24 +10:00
Nyall Dawson
0a365b2d22 Fix OGR algs always export shapefiles, regardless of output file extension 2017-08-14 04:56:24 +10:00
Nyall Dawson
e33647dc5a Move OGR processing provider specific methods to GdalUtils 2017-08-14 04:56:24 +10:00
Nyall Dawson
97a8d1a7a2 Fix failing test 2017-08-14 04:56:24 +10:00
Nyall Dawson
1a5648722a Port GDAL Ogr2OgrPostgis to new API 2017-08-14 04:56:24 +10:00
Nyall Dawson
479106ad80 An empty string parameter should not fallback to default value
Since we need to allow empty strings to override defaults in
some circumstances
2017-08-14 04:56:24 +10:00
Nyall Dawson
d45215ebc1 Cleanup conversion of input layers to OGR compatible sources 2017-08-14 04:56:24 +10:00
Nyall Dawson
6301ff6606 Resurrect OGR points along lines algorithm 2017-08-14 04:56:24 +10:00
Nyall Dawson
ab079f9d92 ogrConnectionString reuses existing context 2017-08-14 04:56:24 +10:00
Nyall Dawson
ce8e18da10 Fix overridden function signatures 2017-08-14 04:56:24 +10:00
Nyall Dawson
5c888c5830 Resurrect gdal warp algorithm 2017-08-14 04:56:24 +10:00
Nyall Dawson
014833a6ff Restore gdal algorithm support 2017-08-14 04:56:24 +10:00
Matthias Kuhn
7768f06776 Document api breaks 2017-08-13 20:19:32 +02:00
Matthias Kuhn
b51a5f7b6f Simplify QgsGeometryEngine code 2017-08-13 20:19:32 +02:00
Matthias Kuhn
e3787effc6 Doxymentation 2017-08-13 20:19:32 +02:00
Matthias Kuhn
581b89e0ec Use pointers and not references to QgsAbstractGeometry
because using this more consistently throughout the codebase makes it
easier to maintain code.
We also do not want to call the copy constructor on them, using pointers
just makes this more obvious. Further, casting is also something
that's commonly done on pointers and not references.

And if you want a value or a reference, just use QgsGeometry, it's meant
to be handled like this.
2017-08-13 20:19:32 +02:00