41575 Commits

Author SHA1 Message Date
Alessandro Pasotti
5614df4b6e Merge pull request #5164 from boundlessgeo/browser_shared_model
[bugfix] Browser shared model
2017-09-12 17:20:13 +02:00
Sandro Mani
9dcdefd68e Merge pull request #5181 from manisandro/ogr_subsetstring
[OGR] Ensure subset string is set when reopening dataset
2017-09-12 16:06:01 +02:00
Sandro Mani
95cd8d744d [OGR] Ensure subset string is set when reopening dataset
QgsOgrProvider::reloadData calls close() and open(), which in turn called setSubsetString with mSubsetString.
Since setSubsetString does nothing if the passed sql string is equal to mSubsetString, this resulted in the
substring not being set on re-open. This commit clears mSubsetString before calling setSubsetString, and
blocks signals when calling setSubsetString to avoid an endless recursion of emit dataChanged -> reload.
Fixes #17122.
2017-09-12 15:26:09 +02:00
Alessandro Pasotti
850fed557f Const getter and api break docs 2017-09-12 15:12:37 +02:00
Alessandro Pasotti
151cd080c9 Typo delayied -> delayed 2017-09-12 15:01:45 +02:00
Alessandro Pasotti
22bd2a35f8 Browser: removed redundant refresh signals 2017-09-12 15:01:45 +02:00
Alessandro Pasotti
6f0950ffee Removed reference 2017-09-12 15:01:45 +02:00
Alessandro Pasotti
3dba091b86 Share QgsBrowserModel among browser instances 2017-09-12 15:01:45 +02:00
Alessandro Pasotti
9349ae8606 Moved the scan time to populated and get it from settings 2017-09-12 15:00:30 +02:00
Alessandro Pasotti
1d4c6061a8 [bugfix] Browser keeps scanning directory with gpkg file
Fixes #17043 by introducing a check for last directory
scan timestamp and skipping the directoryChanged signal
is the last scan was less than 10 seconds in the past.

Tested with > 300 gpkg files in a single directory.
2017-09-12 15:00:30 +02:00
Alexander Bruy
4115d06fba remove context help popup on console opening 2017-09-12 15:47:25 +03:00
Alexander Bruy
999d93ad6e [console] return home directory as string instead of QDir instance (fix #17106) 2017-09-12 15:47:25 +03:00
Nyall Dawson
b26b8d9789 Merge pull request #5165 from Gustry/save_metadata
write metadata with XML
2017-09-12 20:32:08 +10:00
Nyall Dawson
457709d3d8 Merge pull request #5173 from nyalldawson/model_crash_win
[processing] Fix crash in modeler on Windows
2017-09-12 20:13:01 +10:00
Nyall Dawson
cf16a82419 Fix indentation 2017-09-12 19:23:37 +10:00
Mathieu Pellerin
9b8fad515f [ogr provider] insure connection pool updated when subset sql added/changed (#5172) 2017-09-12 15:27:41 +07:00
Alexander Bruy
06c5d24ebb Merge pull request #4440 from alexbruy/gdal-compression
expose image compression in the layer metadata (fix #15702)
2017-09-12 10:32:48 +03:00
Martin Dobias
220b58d0c9 Fix vertex+segment vs segment snapping type
When user picked snapping to current layer / all layers, snapping to
vertex+segment vs segment were working the other way around
(advanced configuration was working correctly though)
2017-09-12 09:25:11 +02:00
Nyall Dawson
6bd37cc506 [processing] Fix crash when editing models on Windows (fix #17028) 2017-09-12 17:12:13 +10:00
Nyall Dawson
4a974eab18 Cleanup model algorithm parameter definition dialog 2017-09-12 17:12:13 +10:00
Etienne Trimaille
814ef78732 write metadata with XML 2017-09-12 07:28:54 +02:00
Nyall Dawson
88c8c71422 Daily Q_FOREACH removal 2017-09-12 10:44:10 +10:00
Nyall Dawson
8fcad6aed9 [processing] List 'All files (*.*)' option last in save as dialogs
See https://ux.stackexchange.com/questions/111689/file-dialog-formats-list-should-all-files-be-listed-first-or-last for discussion:

- for 'file open' dialogs, wildcard options should be listed first
- for 'file save' dialogs, wildcard options should be listed last
2017-09-12 10:20:52 +10:00
Juergen E. Fischer
3d3b6d1a25 Fix windows build 2017-09-12 00:48:40 +02:00
Nyall Dawson
311a24a7d5 Merge pull request #5166 from nyalldawson/tidy
clang-tidy fixes
2017-09-12 05:36:24 +10:00
Martin Dobias
6772541720 CAD dock: fix a typo -> enable new snapping option
When X or Y is locked and user has mouse on top of a segment, CAD dock widget
will snap at the intersection of the segment and the axis.
2017-09-11 17:06:47 +02:00
Martin Dobias
494fa15fe0 Fix node tool sometimes behaving incorrectly with topo editing
This would happen especially when zoomed out due to mismatch of snapping match vs original map point
2017-09-11 16:45:33 +02:00
Martin Dobias
7c9105d0eb Only update CAD canvas item geometry when necessary
The call to setRect() in paint() handler was triggering canvas redraws
all the time, keeping one CPU core busy nearly all the time when
CAD dock was active.
2017-09-11 15:43:20 +02:00
Martin Dobias
bb20047507 Make CAD dock work well with node tool when adding vertex at endpoint 2017-09-11 14:49:26 +02:00
Nyall Dawson
9b04589ce7 More missing docs 2017-09-11 21:55:20 +10:00
Nyall Dawson
6166d21289 Add missing docs 2017-09-11 21:43:15 +10:00
Nyall Dawson
727d20927d Add missing override keyword 2017-09-11 21:30:05 +10:00
Nyall Dawson
ce3ac5f4d6 Fix clang-tidy misleading comment warning 2017-09-11 21:29:47 +10:00
Nyall Dawson
839c3e506a Remove redundant code 2017-09-11 21:29:30 +10:00
Nyall Dawson
7855849677 Use std::move to reassign unique_ptrs 2017-09-11 21:29:02 +10:00
Nyall Dawson
68ad9feab0 Fix clang-tidy int to bool conversion warning 2017-09-11 21:28:41 +10:00
Nyall Dawson
6ca50a023e Fix clang-tidy redundant .get() calls 2017-09-11 21:28:10 +10:00
Nyall Dawson
f2875a9639 Fix clang-tidy redundant return/continue warnings 2017-09-11 21:27:41 +10:00
Nyall Dawson
357f998e44 Remove redundant virtual keyword from signatures with override 2017-09-11 21:27:02 +10:00
Nyall Dawson
b7f21446d9 Fix clang-tidy use emplace_back instead of push_back warnings 2017-09-11 21:26:27 +10:00
Nyall Dawson
2716127969 Remove more unnecessary destructors, flip empty constructors to =default 2017-09-11 21:25:29 +10:00
Nyall Dawson
c17978043c Use .empty() instead of .size() > 0/.size() >=1/etc
Possibly faster, and clearer to read
2017-09-11 21:21:45 +10:00
Nyall Dawson
2a33844416 Pass by const ref where possible 2017-09-11 21:19:22 +10:00
Martin Dobias
68a39a2820 Fix settings icon for CAD dock widget
Previously it used an icon from georeferencer's QRC
2017-09-11 12:53:48 +02:00
Alessandro Pasotti
2e8d7f0378 Fix broken signals for AFS/AMS layer addition from the datasource dialog 2017-09-11 09:26:41 +02:00
Nyall Dawson
c9fa976524 Use =delete to remove default functions
Via clang-tidy modernize-use-equals-delete
2017-09-11 17:11:50 +10:00
Nyall Dawson
d9ebd3b84b Remove some unnecessary delete guards
Via clang-tidy readability-delete-null-pointer
2017-09-11 17:11:50 +10:00
Nyall Dawson
ccf0dc8fa3 Remove some unnecessary initializers
From clang-tidy readability-redundant-member-init
2017-09-11 17:11:50 +10:00
Nyall Dawson
b468ab3ee5 Simplify boolean expressions
By applying clang-tidy readability-simplify-boolean-expr fixit
2017-09-11 17:11:50 +10:00
Nyall Dawson
7afec4bd98 Cleanup pointer comparisons to nullptr 2017-09-11 17:11:50 +10:00