5655 Commits

Author SHA1 Message Date
Nyall Dawson
2ed144ac59 Apply clang-tidy readability-avoid-const-params-in-decls fixit
Checks whether a function declaration has parameters that are
top level const.

const values in declarations do not affect the signature of a
function, so they should not be put there.
2018-06-05 10:19:13 +10:00
Nyall Dawson
e91aed6617 [processing] Force model outputs to respect constraints set by
their underlying algorithm's provider

E.g. for model outputs generated by a saga algorithm, only
sdat and shp files are valid outputs. So only give users choices
of these instead of all formats.

Also fixes temporary file names generated as part of model
execution may use formats which are not compatible with the
algorithm's provider.

Fixes #18908
2018-06-05 10:05:32 +10:00
Even Rouault
6160e066d7
Merge pull request #7167 from rouault/gpkg_perf_improvements
[OGR provider] Performance improvements on huge GeoPackage database (fixes #18402)
2018-06-04 21:34:30 +02:00
Even Rouault
4f531359ae
[OGR provider] Performance improvements on huge GeoPackage database (fixes #18402)
- Introduce an approximate feature count for GeoPackage in case there are
  at least 100,000 rows in a table.
- Add a super fast implementation of GetExtent() for GeoPackage when there
  is an RTree
- Do not require feature count when enumerating layers from the browser
2018-06-04 14:23:55 +02:00
Nyall Dawson
84806b9161 [processing] Fix cannot use feature source as input for model crs or extent parameters 2018-06-04 21:30:12 +10:00
Nyall Dawson
b65ee54527 Fix incorrectly capitalized accented menu entries
Fixes #19102
2018-06-04 18:37:43 +10:00
Matthias Kuhn
36712b9ed2
Merge pull request #7118 from m-kuhn/stringCompOperators
Cast left node to text on string comparison
2018-06-04 09:25:10 +02:00
Nyall Dawson
a1d46de0de [processing] Fix evaluation of vector layer references to compatible feature sources
Refs #18545
2018-06-04 13:57:06 +10:00
Nyall Dawson
1395dc0e9c Add missing license headers 2018-06-04 11:30:32 +10:00
Nyall Dawson
23c3731121 Fix path to licensecheck in test 2018-06-04 11:30:32 +10:00
Nyall Dawson
4bb572f4d0 Move licensecheck to external folder 2018-06-04 11:30:32 +10:00
Nyall Dawson
4e0845b4c6 Include licensecheck.pl script in code_layout test folder
Seems to be the only way to get this functional under Travis.

TODO: remove when Travis is upgraded to a reasonably modern
Ubuntu version
2018-06-04 11:30:32 +10:00
Nyall Dawson
48b117e0db Fail check if licensecheck missing 2018-06-04 11:30:32 +10:00
Nyall Dawson
d16ec3e257 Add unit test for license headers 2018-06-04 11:30:32 +10:00
Nyall Dawson
bb2e15c95a More checks 2018-06-04 06:35:10 +10:00
Nyall Dawson
4ddf58c01c Add feature source test for combination of filterfids AND filterrect
Both these conditions must be honored when set, i.e. features
with matching IDs but which fail the rect check should not be
returned.
2018-06-04 06:35:10 +10:00
Denis Rouzaud
e5b02cd2a8 use dedicated files for auto additions 2018-06-03 11:07:09 -08:00
Nyall Dawson
477fb89fdf More tests 2018-06-03 09:24:35 +10:00
Nyall Dawson
314942d7a2 Also check geometry in tests 2018-06-03 09:24:35 +10:00
Nyall Dawson
f3bc283cd5 Better tests 2018-06-03 09:24:35 +10:00
Even Rouault
f68f288dea
Merge pull request #7145 from rouault/fix_18596
[OGR provider] When editing a GeoJSON file, close and re-open the file at end of editing session (fixes #18596)
2018-06-02 17:32:12 +02:00
Even Rouault
754018a477
[OGR provider] When editing a GeoJSON file, close and re-open the file at end of editing session (fixes #18596) 2018-06-02 12:00:15 +02:00
Even Rouault
9d3f8d44f5
Merge pull request #7140 from rouault/fix_19009
Assorted set of fixes regarding field length for OGR provider
2018-06-01 17:42:59 +02:00
Even Rouault
f4bf1ec907
[OGR provider] GPKG: allow repeated creation of int fields with len != 0 (fixes #19009) 2018-06-01 13:15:41 +02:00
Nyall Dawson
05f426e061 Remove orig_ogc_fid fields from server filter tests 2018-06-01 21:00:20 +10:00
Nyall Dawson
e6e54de383 Add test to ensure that orig_ogc_fid field is only ever used internally
We don't want to expose this field to users, or include it in layer
exports or copies

And rename internal field to __orig_ogc_fid to avoid clashes with
existing datasets which have been exported before this fix and which
now contain a orig_ogc_fid field
2018-06-01 21:00:20 +10:00
Nyall Dawson
f6416a1990 [processing] Fix missing vector inputs when run in batch mode
Fix incorrect definition of compatibleVectorLayers, which was
using layer WKB type values instead of processing source types.
2018-06-01 15:55:11 +10:00
Nyall Dawson
f7a6864b9c [processing] Fix invalid characters in HTML for 'Raster layer unique values' report 2018-06-01 08:53:20 +10:00
Even Rouault
2969ba1e99
test_provider_ogr_gpkg.py: avoid bug_17795.gpkg test sample to be modified by tests 2018-05-31 23:05:37 +02:00
Even Rouault
ee06d52421
[OGR provider] Avoid attribute table to be empty on OGR layer with mixed geom types (fixes #19077) 2018-05-31 23:05:37 +02:00
Even Rouault
1e4b01bb9b
[WFS provider] Add typename prefix before attribute/geometry name for Update requests (fixes #17945)
Deegree requires those namespace prefixes. I've also verified that
GeoServer is indifferent regarding them.
2018-05-31 18:30:39 +02:00
Matthias Kuhn
48bbd2460c
Run string comparison test on all providers 2018-05-31 18:27:16 +02:00
Matthias Kuhn
d1eabe1c2b
Make compiled tests more stable
we do not want to ignore AttributeErrors for those
2018-05-31 18:27:16 +02:00
Matthias Kuhn
dbe4186a9c
Add tests for compiling string operators 2018-05-31 14:04:23 +02:00
Even Rouault
1d2686d0dc
[WFS provider] Handle DescribeFeatureType responses that consist of a single <include> (fixes #18267)
Also handle another occurence of a buggy server only accepting TYPENAMES plural
as parameter of DescribeFeatureType
2018-05-31 13:38:08 +02:00
Nyall Dawson
3aa4968f93 Optimise geometry conversion to/from geos 2018-05-30 18:52:41 +10:00
Nyall Dawson
d4a5df2f2c More unit checks for project dirtying 2018-05-30 14:15:00 +10:00
Nyall Dawson
2a70c4bcca Remove invalid ring handling from filterVertices, move to removeInvalidRings() 2018-05-30 05:01:40 +10:00
Nyall Dawson
53d4d0b40a Fix filterVertices for multipoint geometries 2018-05-30 05:01:40 +10:00
Nyall Dawson
3ba7c0b322 Unit tests for filterVertices 2018-05-30 05:01:40 +10:00
nirvn
5ab3fe4ba0 Add subsetStringChanged signal 2018-05-29 17:10:17 +07:00
Denis Rouzaud
637f59ded1 fix server/app files and sipify test 2018-05-28 10:39:34 -08:00
Denis Rouzaud
6772f0d74e fix test 2018-05-28 10:39:34 -08:00
Denis Rouzaud
70f8266495 add test to check that \since and \deprecated are at the end of command blocks 2018-05-28 10:39:34 -08:00
rldhont
facf7a22f0
Merge pull request #7007 from arnaud-morvan/server_filter_and_bbox
[server][wfs] Apply BBOX inside And using filterRect
2018-05-28 13:07:07 +02:00
arnaud.morvan@camptocamp.com
12a7be799c [server] Apply BBOX inside And using filterRect
In case of a WFS GetFeature request,
if BBOX is not a direct child of the Filter element,
it is applyed through an intersects_bbox function in the QgsFeatureRequest filterExpression.
This is not compiled by providers like PostgreSQL, causing the whole filter to be interpreted on QGIS side.

When interpreted on QGIS side, the srsname given in the request is not handled properly as geom_from_gml return a geometry object, projection agnostic.
This result in a very long request returning no results.

This is a workaround for this performance and srs issue in the case the BBOX is direct child of an And operator,
itself at first level in Filter element.

This is a bug fix and huge optimisation for the case we have a And with a BBOX and another condition.
2018-05-28 11:25:17 +02:00
Nyall Dawson
870d20740c [processing] Tweaks and checks for checkParameterValues 2018-05-28 16:02:38 +10:00
Andrea Aime
c923d5b63f Fixes #16706, categorized symbology matching lack of value is not properly encoded in SLD 2018-05-28 13:05:28 +10:00
Nyall Dawson
f8bc97030b Remove extra space added before first line of docstring 2018-05-28 08:22:11 +10:00
Nyall Dawson
c864d22d1f Add "get ..." to doxygen compliance blacklist
Should be "gets ..." for consistent tense, or better yet
"returns ..." for consistency.
2018-05-27 14:05:06 +10:00