41685 Commits

Author SHA1 Message Date
Nyall Dawson
05e047d779 Generalize some WFS/WMS connection setting handling 2017-09-13 05:47:53 +10:00
Nyall Dawson
4c8733853a Cleanup QgsOwsConnection 2017-09-13 05:47:53 +10:00
Nyall Dawson
51922fc74c Remove duplicate code 2017-09-13 05:47:53 +10:00
Nyall Dawson
42869bb92c Fix build 2017-09-13 05:47:53 +10:00
Nyall Dawson
ffaafa6229 Rework QgsGeoNodeNewConnection to inherit from QgsNewHttpConnection
Avoids a lot of duplicate code.

Note that while this refactoring was done to allow WFS and WMS
settings to be simultaneously visible, I've removed the settings
from the GeoNode connection for now. Looking into this they were
being stored, but not used at all when loading the layers from
the GeoNode instance.
2017-09-13 05:47:53 +10:00
Nyall Dawson
90237fa3bf Cleanup some strings 2017-09-13 05:47:53 +10:00
Nyall Dawson
35eea229aa Rework QgsNewHttpConnection layout so that both WFS and WMS settings
can be shown simultaneously
2017-09-13 05:47:53 +10:00
Nyall Dawson
6134950609 Use explicit flags to set behavior of QgsNewHttpConnection instead of key parsing 2017-09-13 05:47:53 +10:00
Nyall Dawson
88b8741ff5 Fix ordering of Arcgis map server item 2017-09-13 05:47:53 +10:00
Nyall Dawson
2c0019952d Clean comments 2017-09-13 05:47:53 +10:00
Nyall Dawson
af03d2f476 Remove Q_FOREACH, fix inefficient loops 2017-09-13 05:47:53 +10:00
Nyall Dawson
944cb8c4bd Revert unused changes to QgsDataItem 2017-09-13 05:47:53 +10:00
Nyall Dawson
9a8adfc802 Fix spelling 2017-09-13 05:47:53 +10:00
Nyall Dawson
388b37a1a9 Hide non-functional style related browser actions 2017-09-13 05:47:53 +10:00
Nyall Dawson
e25436811b Cleanup and add docs for QgsGeoNodeConnection 2017-09-13 05:47:53 +10:00
Nyall Dawson
e1562df16b [geonode] Don't block data source manager while connecting to a server
Also add missing docstrings
2017-09-13 05:47:53 +10:00
Nyall Dawson
1a19283634 Class shuffle 2017-09-13 05:47:53 +10:00
Nyall Dawson
e6a8980b97 Run all GeoNode tests locally, but skip ones which rely on a remote server on Travis 2017-09-13 05:47:53 +10:00
Nyall Dawson
e803545258 Add missing sip file 2017-09-13 05:47:53 +10:00
Nyall Dawson
4e6516267a Misc optimisations to geonode data items, fix leaks 2017-09-13 05:47:53 +10:00
Nyall Dawson
29539e6712 Move remaining geonode classes from gui->app 2017-09-13 05:47:53 +10:00
Nyall Dawson
5f82705c55 Revert redundant changes to ows provider 2017-09-13 05:47:53 +10:00
Nyall Dawson
b657c1ace6 Move GeoNode data items from OWS provider to app 2017-09-13 05:47:53 +10:00
Nyall Dawson
973ba7bdfc Remove non-functional close button from geonode source select dialog 2017-09-13 05:47:53 +10:00
Nyall Dawson
3fde586bbd Don't link app into provider 2017-09-13 05:47:53 +10:00
Nyall Dawson
d7fff83b38 Include geonode folder in doxyden search folders
Required to build the docs for this folder, and correctly
include the classes in the documentation coverage test
2017-09-13 05:47:53 +10:00
Nyall Dawson
61e70c93a6 Slight folder restructuring 2017-09-13 05:47:53 +10:00
Nyall Dawson
a03e1eeeaa Rollback all geonode specific changes to QgsDataSourceManagerDialog 2017-09-13 05:47:53 +10:00
Nyall Dawson
33b1380413 Add a very trivial registry GeoCMS providers to app
Currently it's only used to register GeoNode source select dialogs.
As additional GeoCMS handling is added to QGIS we can start
refining this class to handle common functionality.

For now, it's locked away in app so we don't need to worry
about frozen API restricting us when this happens.
2017-09-13 05:47:53 +10:00
Nyall Dawson
15f9241109 Add a bit more structure to provider source select ordering 2017-09-13 05:47:20 +10:00
Nyall Dawson
b89c16e3cf Move QgsGeoNodeSourceSelect to app 2017-09-13 05:47:20 +10:00
Nyall Dawson
876936900b Rollback changes to app
There's no need for a dedicated 'Add GeoNode layer' menu entry,
as the unified data source manager has been designed to replace
all these specific provider based actions.
2017-09-13 05:47:20 +10:00
Nyall Dawson
46b1e7d3bb Correctly handle using layer name option 2017-09-13 05:47:20 +10:00
Nyall Dawson
858b93b125 Misc code cleanup 2017-09-13 05:47:20 +10:00
Nyall Dawson
ea4b2dd5b8 Condense code 2017-09-13 05:47:20 +10:00
Nyall Dawson
e6c0ba925f Use correct messagebox type 2017-09-13 05:47:20 +10:00
Nyall Dawson
11240121c1 Fix another leak 2017-09-13 05:47:20 +10:00
Nyall Dawson
026309d99b Fix memory leak 2017-09-13 05:47:20 +10:00
Nyall Dawson
239e353155 Allow QgsAbstractDataSourceWidget subclasses to add vector layers
with a specific provider key
2017-09-13 05:47:20 +10:00
Nyall Dawson
e51a0d4fac Minor code cleanup 2017-09-13 05:47:20 +10:00
Nyall Dawson
a5957af8db Remove unused code 2017-09-13 05:47:20 +10:00
Nyall Dawson
003bf3a76f QgsGeoNodeSourceSelect is a QgsAbstractDataSourceWidget 2017-09-13 05:47:20 +10:00
Nyall Dawson
92a2499076 Fix ui file build warning 2017-09-13 05:47:20 +10:00
Nyall Dawson
80148c983b Use QgsDebugMsg instead of QgsMessageLog for non-error feedback
QgsMessageLog should only be used for errors or warnings,
not 'everything is working ok' type debug messages
2017-09-13 05:47:20 +10:00
Nyall Dawson
378a9e90dd Split QgsGeoNodeConnection into two classes
Move utility functions to QgsGeoNodeConnectionUtils
2017-09-13 05:47:20 +10:00
Nyall Dawson
b7683f209e QgsGeonodeConnection is not a Q_OBJECT 2017-09-13 05:47:20 +10:00
Nyall Dawson
5b092aeb8d Performance optimizations
- avoid container detachments
- use QStringLiteral
2017-09-13 05:47:19 +10:00
Nyall Dawson
b1745b0fea Pass strings by const ref 2017-09-13 05:47:19 +10:00
Nyall Dawson
a46cc54f60 Static members should use a 's' prefix, not 'm' 2017-09-13 05:47:19 +10:00
Ismail Sunni
cad8fa8bb2 Fix can not delete geonode instance from browser. 2017-09-13 05:47:19 +10:00