15 Commits

Author SHA1 Message Date
Denis Rouzaud
42976df82e do not override QDateTimeEdit::dateTimeChanged
see de03186745 (diff-f135574df9edcdda660e1bc4320a053e)
2018-01-04 21:40:55 -04:00
Denis Rouzaud
2528639320 doxymentattion 2018-01-04 21:40:45 -04:00
Denis Rouzaud
d8cc285fd2 fix NULL constraint on date/time widget with allow NULL
the issue was that widget wrapper was using parent QDateTimeEdit::dateTimeChanged signal. It was connected both internally to QgsDateTimeEdit::changed and in the form to detect changes. When QgsAttributeForm was recreating the updated feature it was calling QgsDateTimeEdit::value() before changed() could update the value (i.e. setting mIsNull to false).

fix #17790
2018-01-04 20:38:51 -04:00
Denis Rouzaud
230e91c44b [date time widget] do not use minimumDateTime for NULL values
fixes issue when setting min and max values for the widget
2018-01-02 20:41:24 -04:00
Denis Rouzaud
39b183fef4 remove include and forward declarations left-overs 2018-01-01 20:09:46 -04:00
Denis Rouzaud
7237dab6ec [QDateTimeEdit] use QLineEdit::addAction
instead of custom tool button
this seems to solve many issues :)
kudos to @nyalldawson for pointing to it
and a happy new year!
2018-01-01 20:09:46 -04:00
Denis Rouzaud
86feed4955 [QgsDateTimeEdit] use special value text to handle NULL values
the widget now uses a special value text to display NULL rather than painting a QLineEdit on top

a press on the spinbox buttons (non-calendar mode) is catch to set to current date to avoid starting at the minimum date
2018-01-01 20:09:46 -04:00
Denis Rouzaud
c604d2dda6 run sipify 2017-12-15 22:13:44 -04:00
Nyall Dawson
4da1ce8404 Drop redundant virtual keywords on overrides
Run clang-tidy modernize-use-override to remove all the redundant
virtual keywords from overridden methods, and add some missing
overrides.

Another benefit is that this has also added the overrides
on destructors, which will cause a build failure if a base
class is missing a virtual destructor.
2017-12-16 08:49:36 +10:00
Denis Rouzaud
f2b3ed0a9b run sipify 2017-12-15 11:12:19 -04:00
Nyall Dawson
a15b54d997 Swap missing 0->nullptr and add missing overrides 2017-12-12 21:14:58 +11:00
Denis Rouzaud
0824280296 sipify gui editor widgets 2017-05-09 08:59:07 +02:00
Denis Rouzaud
7b60d89d6c align pointer and reference in sip files batch 2 2017-05-01 20:00:51 +02:00
Nyall Dawson
6d868598f5 Add an interderminant "empty" state for QgsDateTimeEdit 2016-05-24 00:26:14 +10:00
Juergen E. Fischer
abd4a04399 sip update 2015-02-03 02:21:52 +01:00