43697 Commits

Author SHA1 Message Date
Matthias Kuhn
032ca68ba3
Merge pull request #5572 from signedav/valuerelationwidget
Value relation widget takes key again instead of value (in Attribute Form)

Fix #17261
2017-11-09 11:11:38 +01:00
Blottiere Paul
7f37e70762 Add test 2017-11-09 09:31:43 +00:00
Blottiere Paul
ac24c4a37e Fixes #17401 by replacing '+' symbol by space 2017-11-09 09:30:14 +00:00
Juergen E. Fischer
1ff50fd59e fix TestQgsFileDownloader::testLacksWritePermissionsError (followup f06ea878) 2017-11-09 09:16:55 +01:00
Alessandro Pasotti
3fc4be3f10 [auth] Remove unused accessor to mutex 2017-11-09 09:02:54 +01:00
David
2daae54d16 Attribute Form - value relation widget takes key again instead of value
Corrected: Value relation widget update incorrectly tries to use value instead of key

The mapped key has to be set in the return value (not the input value).
In the release-2_18 the key was returned correctly but in another structure. So this is corrected now.
2017-11-09 08:46:26 +01:00
Mathieu Pellerin
0ccf6fa171
Fix Z and M support for add point feature (fixes #17427) 2017-11-09 12:36:22 +07:00
Nyall Dawson
ba62ffce2c Make constructors for QgsVectorLayer and QgsRasterLayer more flexible
...by moving extra arguments to new LayerOptions structs. This allows
us to more easily add new layer constructor options without making
the API cumbersome to use.
2017-11-09 14:28:51 +11:00
Matthias Kuhn
61b2f74aae Do not assume edit widget value changes on every signal
Widgets may on initialisation send out a notification that the value changed (from invalid to something sensible).

The attribute form should however only tell the rest of the world, that a value changed if the new value doesn't
correspond to the one in the cached QgsFeature.

Fix #17425
2017-11-09 02:18:11 +01:00
Matthias Kuhn
dca0dc1dd5 Fix crash when removing layers from running transactions
qobject_cast no longer works when the QObject::destryed signal is being emitted
2017-11-09 02:17:39 +01:00
Matthias Kuhn
78622b4816
Merge pull request #5568 from m-kuhn/postgresDefaultValues
[postgres] Fix default value check if evaluated server side
2017-11-09 01:46:30 +01:00
Matthias Kuhn
b18c891dfc [postgres] Fix default value check if evaluated server side 2017-11-09 01:19:35 +01:00
Nyall Dawson
cab807dc30
Merge pull request #5426 from medspx/ProcessingPortGrass72
[Processing] Port GRASS 7.2 algorithm provider
2017-11-09 06:42:38 +10:00
Matthias Kuhn
e1ffb2826b QgsHighlight improvements
* Doxygen improvements
* Fix unrequired casting
* Remove unrequired contructor
2017-11-08 21:17:00 +01:00
Matthias Kuhn
d79ac26fda
Fix build warning 2017-11-08 17:50:59 +01:00
Matthias Kuhn
140b9568b9
Merge pull request #5467 from signedav/propertieslayout
Propertieslayout Fields And Forms Redesign
2017-11-08 17:46:11 +01:00
David
0ba8f97979 no +/- buttons when not needed and some graphical finetuning
scroll area for attribute type config, but no scroll area for whole tab
set attribute type config to invisible when a container box is selected
2017-11-08 16:53:04 +01:00
Nathan Woodrow
7b427c6be5 Don't quote symbol path in crash 2017-11-09 00:57:04 +10:00
Matthias Kuhn
be5a0c9a01
Merge pull request #5556 from m-kuhn/crashOnHighlight
No need to crash when a user wants a highlight
2017-11-08 15:25:23 +01:00
Mathieu Pellerin
17c7e2fbca
[3D] Fix missing Z support for point layers (#5560) 2017-11-08 21:04:58 +07:00
Matthias Kuhn
fd937c3a86
Increase outline width 2017-11-08 14:37:17 +01:00
Matthias Kuhn
42c9d158cf
[test] Fix canvas size and background garbage 2017-11-08 14:37:16 +01:00
Matthias Kuhn
593bff2cf7
Add control images to highlight check 2017-11-08 14:37:16 +01:00
Matthias Kuhn
05868c21fb
Add smoke test for QgsHighlight 2017-11-08 14:37:16 +01:00
Matthias Kuhn
dc7ec1e1ca
No need to crash when a user wants a highlight
Fix #17413
2017-11-08 14:37:16 +01:00
David
ccd142fef6 Correct order of column headers in relationmanager
The column headers of "Referenced Field" and "Referenced Layer" were switched with respect to their content. Changed to the correct order in GUI now.

Fix #17409
2017-11-08 13:42:53 +01:00
Alessandro Pasotti
6b9b513ea5 [bugfix] Fixes QgsFileDownloader abort on error
Abort reply on error.

Fixes #171410

Requires backport
2017-11-08 13:33:27 +01:00
Alessandro Pasotti
f06ea878b8 Add a test case for unwriteable folders in file downloader
Attempt to verify bug 17410 Identify tool->download in a not authorised folder block qgis

The test passes, so let's push it in, I'll continue
to investigate if there is an issue in the GUI logic.
2017-11-08 13:01:46 +01:00
Alessandro Pasotti
e781ad2e3e
Merge pull request #5558 from elpaso/project_use_rw_context
[bugfix] Project use rw context
2017-11-08 12:26:45 +01:00
Alessandro Pasotti
d11ea073c7 Removed Q_UNUSED 2017-11-08 12:25:59 +01:00
Alessandro Pasotti
87117a8b04 [auth][bugfix] Tests for the new SSL key loading logic 2017-11-08 12:20:38 +01:00
Alessandro Pasotti
d09d7048fa [auth][bugfix] Import pvt keys with unknown file extension
This fixes an unreported bug that prevent imports of
private keys with wrong/unknown extension.

The old logic relied on the file extension, that is
not only weak but plain wrong because the same extension
can have different encodings.

The new implementation is 100% robust because completely
ignores the file extentions and try to load the key with
all supported encodings and algorithms before giving up.
2017-11-08 12:16:15 +01:00
Borys Jurgiel
845310091d Fix histogram refreshig 2017-11-08 10:28:16 +01:00
Blottiere Paul
1119dc89ac
Merge pull request #5551 from pblottiere/reenable_wms_server_tests
[travis] Re-enable WMS tests for server
2017-11-08 09:24:52 +00:00
David
de33017b17 Fix #17412 Sorting fixed, no troubles when editing after sorting
Issue was, that the cellchange is triggered at re-sorting - so we need to check the names
Following issue was, that when removing or renaming something in re-sorted table - so there was a bug that referenced to the row instead of the index
Thought about to remove mIndexedWidgets completely, but when renumbering after delete in unsorted table, we cannot reference to the row order.
2017-11-08 10:18:51 +01:00
Blottiere Paul
24f38aba12 Update some images/masks 2017-11-08 08:44:37 +00:00
Blottiere Paul
ab2603e5cd Re enable WMS server tests 2017-11-08 08:44:37 +00:00
Alessandro Pasotti
1fdfecfc26 Removed unused code 2017-11-08 08:08:52 +01:00
Nyall Dawson
8ae1b62431 Immediately set focus on name line edit after clicking "new projection"
Since it's most likely the very next thing the user wants to edit
2017-11-08 08:39:22 +10:00
Nyall Dawson
f68e42900b When testing custom projections, show geographic results in degrees not radians
Fixes #7036
2017-11-08 08:36:37 +10:00
Nyall Dawson
2d9b573842 Make custom projections dialog a bit more user friendly
...by updating the list immediately when changes are made to the
current projection's name or definition. Previously the list
was only updated when a new item in the list was clicked, but that
made it appear as though the current changes were not applied
immediately and left users looking for a "save" button to actually
lock-in their changes.

By updating the list immediately we make it obvious that the
changes apply immediately and no further action is required (except
for hitting OK on the dialog!)
2017-11-08 08:21:58 +10:00
Nyall Dawson
e45c294449 Move 'copy crs' button to more logical place in dialog
Since the copy is actually copying the definition OVER the
current crs definition (as opposed to adding a NEW custom
crs with the copied definition), it should sit next to the
definition box and not in the same space as the add crs
button.
2017-11-08 08:13:38 +10:00
Nyall Dawson
c8a62c5c06 Fix bad logic in custom projections dialog (fixes #17258) 2017-11-08 08:04:37 +10:00
Nyall Dawson
108de77169 More use of unique_ptrs to simplify sqlite3 memory management 2017-11-08 07:52:01 +10:00
Juergen E. Fischer
940c4ed5c5 followup a1024905b 2017-11-07 22:49:37 +01:00
Nyall Dawson
7d3e491716 Safer sqlite3 memory management using unique_ptr subclass 2017-11-08 07:31:38 +10:00
Borys Jurgiel
61a155cf78
Merge pull request #5547 from borysiasty/stickytabs2
Make some QgsOptionsDialogBase's slots virtual
2017-11-07 22:21:04 +01:00
Borys Jurgiel
4677026c3e
Merge pull request #5532 from borysiasty/nopreloading
[Plugin manager] [needs-doc] Don't preload all plugins for a test
2017-11-07 22:19:57 +01:00
Nyall Dawson
30a1f87b81 Minor cleanups 2017-11-08 07:16:22 +10:00
Nyall Dawson
6143e6da63 More formatting standardisation 2017-11-08 07:14:13 +10:00