Run clang-tidy modernize-use-override to remove all the redundant
virtual keywords from overridden methods, and add some missing
overrides.
Another benefit is that this has also added the overrides
on destructors, which will cause a build failure if a base
class is missing a virtual destructor.
Rationale:
- there was a lot of large objects passed by value, so potentially
there's a speed bump from this
- even for implicitly shared classes like QString/QList there's still
a (small) cost for copying the objects when there's no reason to
- it's the right thing to do!
It has long been in Qt 4 that the WFlags window flags argument has been
renamed to WindowFlags. In fact, WFlags is just a typedef to WindowFlags.
In Qt 5, this will go away, so we can change this now to make transition
easier in the future.
This should not have any affect on API or ABI, as the symbol names already
have WindowFlags in them anyway.
This change concentrates on the sources in the src directory. There are
a few more places in the python directory that can be done later.
vertex warning dialog box)
Also includes a small re-organisation of the QgsMessageViewer class
git-svn-id: http://svn.osgeo.org/qgis/trunk@7668 c8812cc2-4d05-0410-92ff-de0c093fc19c
required changes in all code that uses QgsMessageViewer)
- Improvements to messages when qgis can't find a key column in a
postgres table
- Fix a couple of bugs when loading postgres tables (invalid layers
would appear to load, giving a legend entry, but not show anything on
the map)
- Tidy up of #includes in postgres files
git-svn-id: http://svn.osgeo.org/qgis/trunk@4911 c8812cc2-4d05-0410-92ff-de0c093fc19c
