22 Commits

Author SHA1 Message Date
Nyall Dawson
0799835292 Fix clazy skipped-base-method warnings 2018-02-02 19:52:01 +11:00
Nyall Dawson
a87d352bd7 Run clang-tidy modernize-use-default-member-init to move member
initialization to headers (c++11 style)
2017-09-27 05:02:34 +10:00
Alexandre Neto
8d4dec5c3f Making dialog titles use Book Style Capitalization [needs-docs] 2017-07-26 15:16:36 +01:00
Nyall Dawson
ae59e35dac Complete daily allocation of Qt5 connect transitions 2017-04-04 09:40:25 +10:00
Denis Rouzaud
e7079eead9 run astyle on src/gui 2017-03-03 09:09:37 +01:00
Nyall Dawson
4166a3ea62 Fix most clazy qstring-unneeded-heap-allocations warnings
By flipping string literals to QStringLiteral/QLatin1String

see

https://woboq.com/blog/qstringliteral.html
2016-10-24 15:26:24 +10:00
Matthias Kuhn
e9b4b0c666 Pass enums by value 2016-07-23 00:20:29 +02:00
Matthias Kuhn
7b3e667282 Remove more debug noise 2016-06-12 16:05:40 +02:00
Nyall Dawson
846c6183ca Initially set focus to text in new name dialog 2016-04-07 18:47:01 +10:00
Nyall Dawson
576875e998 Followup 320c696 use clang-modernize to replace 0/NULL use with nullptr 2015-12-15 11:24:51 +11:00
Nyall Dawson
ee720796a3 Change size()/count() == 0 and count() > 0 to isEmpty() checks
Because:
- easier to read
- follows recommendations by clazy/KDAB
- potentially performance benefits
2015-12-08 22:45:06 +11:00
Nyall Dawson
b7e1cae4f0 Switch double quoted single character to single quotes for some
QString methods

Using single quotes is a significant performance boost. Rough
benchmarks indicate the QString single quote methods take
about 15% of the time the double quote variants take.
2015-11-02 17:55:08 +11:00
Nyall Dawson
5ed3d1b73f Use QString::arg multi argument method to avoid extra heap allocations 2015-10-15 17:51:06 +11:00
Nyall Dawson
c49b5b777f Change a lot of arguments to const references in core/gui
Rationale:
- there was a lot of large objects passed by value, so potentially
there's a speed bump from this
- even for implicitly shared classes like QString/QList there's still
a (small) cost for copying the objects when there's no reason to
- it's the right thing to do!
2015-10-07 12:02:04 +11:00
Nyall Dawson
f628ebd423 Replace foreach with Q_FOREACH
For:
- consistency
- to make it immediately clear that this is a Qt macro and that it
works slightly differently to c++ for loops
2015-09-09 19:17:29 +10:00
Nyall Dawson
7c10760225 Followup 73ffb83a, finishing changing all Q_FOREACH to references 2015-09-09 19:17:19 +10:00
Nyall Dawson
ca04bb6409 Allow more customisation of QgsNewNameDialog 2015-08-20 16:09:52 +10:00
Juergen E. Fischer
0853ead242 translation fix 2015-07-14 00:34:35 +02:00
Radim Blazek
fe8263bfda [GRASS] new names fixes 2015-06-25 12:39:09 +02:00
Nyall Dawson
bfcc0cbf47 Add some spacing to new name dialog 2015-06-18 16:25:42 +10:00
Juergen E. Fischer
173ee45405 fix windows build 2015-05-16 21:35:00 +02:00
Radim Blazek
d88f77fbc2 new class QgsNewNameDialog - ask for a new name showing conflicts with existing names 2015-05-16 13:02:54 +02:00