When user was coming with mouse to a vertex of the locked feature
from a different feature, it could happen that the vertex would not
get picked by vertex tool - this was because snapToEditableLayer()
keeps the last snap which would belong to a different feature, but
that feature was not allowed (blocking a new snap).
The fix makes sure that with a locked feature its matches always win.
A small UX improvement: after right click in a location with feature A and B,
we would do a loop A - B - nothing - A - B - nothing ...
But if after first click to get A locked user would move the mouse a bit,
the loop would get broken and would end up with A - nothing - B - nothing - A - B - nothing
The fix is to identify where we are in the cycle and set the index correctly after mouse move.
It was a bit strange effect when locking feature... when moving mouse
over a feature it would have highlight, then on right click it would
also get vertex editor square markers in addition to the highlight, but
then immediately after mouse move the original highlight would be gone.
Now it's simplified so that feature highlight on right click gets removed.
* fixes#20516 : Allow Constraint widget in attribute type form to be empty so expression could be removed
per widget modification
* correct tests
* Add the clear button on field expression widget when widget is allowed to be empty
* Change API since version to 3.6
This is called several times and can slow down substantially
the opening of the attribute table.
Partially fixes#21303 (down from ~30 to ~6 seconds on a remote
connection)
The remaining ~4 seconds (compared to ~2 seconds in 2.18) are due
to the check for enums and provider-side constraints, that were
not implemented in 2.18.
See: QgsEnumerationWidgetFactory::fieldScore and the call to
enumValues for details, fieldScore is called several times
because QgsAttributeTableModel::loadAttributes is also
called multiple times and it queries for widget configuration
all the times.
This is a continuation of:
- #8db3dead87e385f2798356d
- #5c97d22b16320874dbe1
This commit only affects users that have multiple GRASS installations on
their Macs. Using the most recent GRASS version is what we do on Linux too.
