From ffb2817afb67e6e147c910e94ab88b61985e150c Mon Sep 17 00:00:00 2001 From: Matthias Kuhn Date: Tue, 10 Apr 2018 23:10:35 +0200 Subject: [PATCH] Protect the const-ituional correctness --- .../qgsprocessingalgorithmconfigurationwidget.sip.in | 4 ++-- python/gui/processing/qgsprocessingguiregistry.sip.in | 2 +- .../processing/qgsprocessingalgorithmconfigurationwidget.h | 4 ++-- src/gui/processing/qgsprocessingconfigurationwidgets.cpp | 4 ++-- src/gui/processing/qgsprocessingconfigurationwidgets.h | 4 ++-- src/gui/processing/qgsprocessingguiregistry.cpp | 2 +- src/gui/processing/qgsprocessingguiregistry.h | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in b/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in index 157b8eca416..c69a8a33fd0 100644 --- a/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in +++ b/python/gui/processing/qgsprocessingalgorithmconfigurationwidget.sip.in @@ -58,12 +58,12 @@ Interface base class for factories for algorithm configuration widgets. public: virtual ~QgsProcessingAlgorithmConfigurationWidgetFactory(); - virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const = 0 /Factory/; + virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const = 0 /Factory/; %Docstring Create a new configuration widget for ``algorithm``. %End - virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const = 0; + virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const = 0; %Docstring Check if this factory can create widgets for ``algorithm``. %End diff --git a/python/gui/processing/qgsprocessingguiregistry.sip.in b/python/gui/processing/qgsprocessingguiregistry.sip.in index 6bcaf12436e..18a511ee8e6 100644 --- a/python/gui/processing/qgsprocessingguiregistry.sip.in +++ b/python/gui/processing/qgsprocessingguiregistry.sip.in @@ -48,7 +48,7 @@ widgets. .. versionadded:: 3.2 %End - QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const; + QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const; %Docstring Get the configuration widget for an ``algorithm``. This widget will be shown next to parameter widgets. Most algorithms do not have a configuration widget diff --git a/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h b/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h index 77ee045f7cc..2474280f661 100644 --- a/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h +++ b/src/gui/processing/qgsprocessingalgorithmconfigurationwidget.h @@ -73,12 +73,12 @@ class CORE_EXPORT QgsProcessingAlgorithmConfigurationWidgetFactory /** * Create a new configuration widget for \a algorithm. */ - virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const = 0 SIP_FACTORY; + virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const = 0 SIP_FACTORY; /** * Check if this factory can create widgets for \a algorithm. */ - virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const = 0; + virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const = 0; }; diff --git a/src/gui/processing/qgsprocessingconfigurationwidgets.cpp b/src/gui/processing/qgsprocessingconfigurationwidgets.cpp index 59357aaca4b..47f0054a01b 100644 --- a/src/gui/processing/qgsprocessingconfigurationwidgets.cpp +++ b/src/gui/processing/qgsprocessingconfigurationwidgets.cpp @@ -148,7 +148,7 @@ void QgsFilterAlgorithmConfigurationWidget::addOutput() mOutputExpressionWidget->setCellWidget( rowIndex, 2, new QCheckBox() ); } -QgsProcessingAlgorithmConfigurationWidget *QgsFilterAlgorithmConfigurationWidgetFactory::create( QgsProcessingAlgorithm *algorithm ) const +QgsProcessingAlgorithmConfigurationWidget *QgsFilterAlgorithmConfigurationWidgetFactory::create( const QgsProcessingAlgorithm *algorithm ) const { if ( algorithm->name() == QStringLiteral( "filter" ) ) return new QgsFilterAlgorithmConfigurationWidget(); @@ -156,7 +156,7 @@ QgsProcessingAlgorithmConfigurationWidget *QgsFilterAlgorithmConfigurationWidget return nullptr; } -bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( QgsProcessingAlgorithm *algorithm ) const +bool QgsFilterAlgorithmConfigurationWidgetFactory::canCreateFor( const QgsProcessingAlgorithm *algorithm ) const { if ( algorithm->name() == QStringLiteral( "filter" ) ) return true; diff --git a/src/gui/processing/qgsprocessingconfigurationwidgets.h b/src/gui/processing/qgsprocessingconfigurationwidgets.h index b92db38e603..67473f337a6 100644 --- a/src/gui/processing/qgsprocessingconfigurationwidgets.h +++ b/src/gui/processing/qgsprocessingconfigurationwidgets.h @@ -50,8 +50,8 @@ class QgsFilterAlgorithmConfigurationWidget : public QgsProcessingAlgorithmConfi class QgsFilterAlgorithmConfigurationWidgetFactory : public QgsProcessingAlgorithmConfigurationWidgetFactory { public: - virtual QgsProcessingAlgorithmConfigurationWidget *create( QgsProcessingAlgorithm *algorithm ) const override; - virtual bool canCreateFor( QgsProcessingAlgorithm *algorithm ) const override; + virtual QgsProcessingAlgorithmConfigurationWidget *create( const QgsProcessingAlgorithm *algorithm ) const override; + virtual bool canCreateFor( const QgsProcessingAlgorithm *algorithm ) const override; }; ///@endcond diff --git a/src/gui/processing/qgsprocessingguiregistry.cpp b/src/gui/processing/qgsprocessingguiregistry.cpp index 2595af0ccf9..dcedac93459 100644 --- a/src/gui/processing/qgsprocessingguiregistry.cpp +++ b/src/gui/processing/qgsprocessingguiregistry.cpp @@ -42,7 +42,7 @@ void QgsProcessingGuiRegistry::removeAlgorithmConfigurationWidgetFactory( QgsPro delete factory; } -QgsProcessingAlgorithmConfigurationWidget *QgsProcessingGuiRegistry::algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const +QgsProcessingAlgorithmConfigurationWidget *QgsProcessingGuiRegistry::algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const { for ( const auto *factory : mAlgorithmConfigurationWidgetFactories ) { diff --git a/src/gui/processing/qgsprocessingguiregistry.h b/src/gui/processing/qgsprocessingguiregistry.h index 8d2f3d74e63..7b9611aa695 100644 --- a/src/gui/processing/qgsprocessingguiregistry.h +++ b/src/gui/processing/qgsprocessingguiregistry.h @@ -68,7 +68,7 @@ class GUI_EXPORT QgsProcessingGuiRegistry * * \since QGIS 3.2 */ - QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( QgsProcessingAlgorithm *algorithm ) const; + QgsProcessingAlgorithmConfigurationWidget *algorithmConfigurationWidget( const QgsProcessingAlgorithm *algorithm ) const; private: