address Nyall's comments:

- add TransferThis to parent argument
 - QSignalSpy always available with Qt5
This commit is contained in:
Alexander Bruy 2017-04-08 08:29:38 +03:00
parent 4a4b3184ef
commit fc4ce3c562
3 changed files with 4 additions and 10 deletions

View File

@ -23,7 +23,7 @@ class QgsCheckableComboBox : QComboBox
public:
QgsCheckableComboBox( QWidget *parent = 0 );
QgsCheckableComboBox( QWidget *parent /TransferThis/ = 0 );
%Docstring
Constructor for QgsCheckableComboBox.
\param parent parent object

View File

@ -124,7 +124,7 @@ class GUI_EXPORT QgsCheckableComboBox : public QComboBox
/** Constructor for QgsCheckableComboBox.
* \param parent parent object
*/
QgsCheckableComboBox( QWidget *parent = nullptr );
QgsCheckableComboBox( QWidget *parent SIP_TRANSFERTHIS = nullptr );
/** Returns separator used to separate items in the display text.
* \see setSeparator()

View File

@ -15,14 +15,9 @@ __revision__ = '$Format:%H$'
import qgis # NOQA
from qgis.PyQt.QtCore import Qt
from qgis.PyQt.QtTest import QSignalSpy
from qgis.gui import QgsCheckableComboBox
try:
from qgis.PyQt.QtTest import QSignalSpy
use_signal_spy = True
except:
use_signal_spy = False
from qgis.testing import start_app, unittest
start_app()
@ -51,7 +46,6 @@ class TestQgsCheckableComboBox(unittest.TestCase):
w.setItemCheckState(2, Qt.Unchecked)
self.assertEqual(w.itemCheckState(2), Qt.Unchecked)
@unittest.skipIf(not use_signal_spy, "No QSignalSpy available")
def test_ChangedSignals(self):
""" test that signals are correctly emitted when clearing"""