sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-10-04 00:04:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(QObjectUniquePtr): delete currently pointed object when moving

Browse Source
This commit is contained in:
Julien Cabieces 2025-09-29 16:33:34 +02:00 committed by Nyall Dawson
parent beb3e987f0
commit f580afd7a6
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/core/qobjectuniqueptr.h
View File

@ -91,6 +91,7 @@ class QObjectUniquePtr
QObjectUniquePtr &operator=( QObjectUniquePtr &&other ) noexcept
{
delete mPtr.data();
mPtr = other.mPtr;
other.clear();
return *this;

12
tests/src/core/testqobjectuniqueptr.cpp
View File

@ -136,6 +136,18 @@ void TestQObjectUniquePtr::testVector()
QCOMPARE( objects.at( 0 )->objectName(), "TESTA" );
QCOMPARE( objects.at( 1 )->objectName(), "TESTB" );
int nbObjectDestroyed = 0;
auto onDestroyed = [&nbObjectDestroyed]() { nbObjectDestroyed++; };
connect( objects.at( 0 ), &QObject::destroyed, this, onDestroyed );
connect( objects.at( 1 ), &QObject::destroyed, this, onDestroyed );
objects.erase( objects.cbegin() );
QCOMPARE( objects.size(), 1 );
QCOMPARE( nbObjectDestroyed, 1 );
QCOMPARE( objects.at( 0 )->objectName(), "TESTB" );
}