From f3d53b8de9933035b3c5beb5dcdc48401e89f719 Mon Sep 17 00:00:00 2001 From: Nyall Dawson Date: Tue, 7 Feb 2017 13:03:18 +1000 Subject: [PATCH] Fix inefficient code --- src/core/symbology-ng/qgsgraduatedsymbolrenderer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/symbology-ng/qgsgraduatedsymbolrenderer.cpp b/src/core/symbology-ng/qgsgraduatedsymbolrenderer.cpp index e6a168865de..63ce0b025f2 100644 --- a/src/core/symbology-ng/qgsgraduatedsymbolrenderer.cpp +++ b/src/core/symbology-ng/qgsgraduatedsymbolrenderer.cpp @@ -828,9 +828,9 @@ void QgsGraduatedSymbolRenderer::updateClasses( QgsVectorLayer* vlayer, Mode mod if ( !ok || values.isEmpty() ) return; - std::sort( values.begin(), values.end() ); // vmora: is wondering if O( n log(n) ) is really necessary here, min and max are O( n ) - minimum = values.first(); - maximum = values.last(); + auto result = std::minmax_element( values.begin(), values.end() ); + minimum = *result.first; + maximum = *result.second; valuesLoaded = true; } else