sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-02-27 00:33:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9064 from mhugo/fix_20831

Browse Source 
Avoid undefined behaviour with signed integer overflow
This commit is contained in:
Hugo Mercier 2019-02-04 08:29:36 +01:00 committed by GitHub
commit ed45181bee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/editorwidgets/qgsrangewidgetwrapper.cpp
View File

@ -145,12 +145,12 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )
int minval = min.toInt();
if ( allowNull )
{
int stepval = step.isValid() ? step.toInt() : 1;
int newMinval = minval - stepval;
uint stepval = step.isValid() ? step.toUInt() : 1;
// make sure there is room for a new value (i.e. signed integer does not overflow)
if ( newMinval < minval )
int minvalOverflow = uint( minval ) - stepval;
if ( minvalOverflow < minval )
{
minval = newMinval;
minval = minvalOverflow;
}
mIntSpinBox->setValue( minval );
QgsSpinBox *intSpinBox( qobject_cast<QgsSpinBox *>( mIntSpinBox ) );