Address review comments

This commit is contained in:
Nyall Dawson 2019-06-28 07:16:36 +10:00
parent da79b6f0e6
commit ec86fcef8d

View File

@ -910,7 +910,7 @@ QDomElement QgsTextBackgroundSettings::writeXml( QDomDocument &doc, const QgsRea
d->paintEffect->saveProperties( doc, backgroundElem ); d->paintEffect->saveProperties( doc, backgroundElem );
if ( d->markerSymbol ) if ( d->markerSymbol )
backgroundElem.appendChild( QgsSymbolLayerUtils::saveSymbol( QStringLiteral( "marker" ), d->markerSymbol.get(), doc, context ) ); backgroundElem.appendChild( QgsSymbolLayerUtils::saveSymbol( QStringLiteral( "markerSymbol" ), d->markerSymbol.get(), doc, context ) );
return backgroundElem; return backgroundElem;
} }
@ -2230,7 +2230,7 @@ void QgsTextRenderer::drawBackground( QgsRenderContext &context, QgsTextRenderer
return; return;
double sizeOut = 0.0; double sizeOut = 0.0;
// only one size used for SVG sizing/scaling (no use of shapeSize.y() or Y field in gui) // only one size used for SVG/marker symbol sizing/scaling (no use of shapeSize.y() or Y field in gui)
if ( background.sizeType() == QgsTextBackgroundSettings::SizeFixed ) if ( background.sizeType() == QgsTextBackgroundSettings::SizeFixed )
{ {
sizeOut = context.convertToPainterUnits( background.size().width(), background.sizeUnit(), background.sizeMapUnitScale() ); sizeOut = context.convertToPainterUnits( background.size().width(), background.sizeUnit(), background.sizeMapUnitScale() );