diff --git a/src/gui/qgssourceselectproviderregistry.cpp b/src/gui/qgssourceselectproviderregistry.cpp
index 1fd0ceb9b4d..7d576f41cbc 100644
--- a/src/gui/qgssourceselectproviderregistry.cpp
+++ b/src/gui/qgssourceselectproviderregistry.cpp
@@ -91,8 +91,8 @@ void QgsSourceSelectProviderRegistry::init()
   {
     return;
   }
-  QStringList providersList = QgsProviderRegistry::instance()->providerList();
-  Q_FOREACH ( const QString &key, providersList )
+  const QStringList providersList = QgsProviderRegistry::instance()->providerList();
+  for ( const QString &key : providersList )
   {
     std::unique_ptr< QLibrary > library( QgsProviderRegistry::instance()->createProviderLibrary( key ) );
     if ( !library )