From e3205654c7465fa16c2d83c34d2713f74926fbfc Mon Sep 17 00:00:00 2001
From: lbartoletti <l.bartoletti@free.fr>
Date: Mon, 9 Oct 2017 13:06:46 +0200
Subject: [PATCH] Requests for QgsMapToolCircle2TangentsPoint

---
 src/app/qgsmaptoolcircle2tangentspoint.cpp | 16 ++++------------
 src/app/qgsmaptoolcircle2tangentspoint.h   |  2 +-
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/src/app/qgsmaptoolcircle2tangentspoint.cpp b/src/app/qgsmaptoolcircle2tangentspoint.cpp
index f90f916aa1f..4eeab24364e 100644
--- a/src/app/qgsmaptoolcircle2tangentspoint.cpp
+++ b/src/app/qgsmaptoolcircle2tangentspoint.cpp
@@ -24,6 +24,7 @@
 #include "qgsstatusbar.h"
 #include "qgslinestring.h"
 #include "qgsmultipolygon.h"
+#include "qgsspinbox.h"
 #include <memory>
 #include <QMouseEvent>
 
@@ -31,13 +32,11 @@ QgsMapToolCircle2TangentsPoint::QgsMapToolCircle2TangentsPoint( QgsMapToolCaptur
     QgsMapCanvas *canvas, CaptureMode mode )
   : QgsMapToolAddCircle( parentTool, canvas, mode )
 {
-  mCenters.clear();
 }
 
 QgsMapToolCircle2TangentsPoint::~QgsMapToolCircle2TangentsPoint()
 {
   deleteRadiusSpinBox();
-  mCenters.clear();
 }
 
 void QgsMapToolCircle2TangentsPoint::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
@@ -83,10 +82,7 @@ void QgsMapToolCircle2TangentsPoint::cadCanvasReleaseEvent( QgsMapMouseEvent *e
       mTempRubberBand = nullptr;
     }
 
-    for ( int i = 0; i < mRubberBands.size() ; ++i )
-    {
-      delete mRubberBands.at( i );
-    }
+    qDeleteAll( mRubberBands );
     mRubberBands.clear();
 
     deactivate();
@@ -226,7 +222,7 @@ void QgsMapToolCircle2TangentsPoint::getPossibleCenter( )
 void QgsMapToolCircle2TangentsPoint::createRadiusSpinBox()
 {
   deleteRadiusSpinBox();
-  mRadiusSpinBox = new QSpinBox();
+  mRadiusSpinBox = new QgsSpinBox();
   mRadiusSpinBox->setMaximum( 99999999 );
   mRadiusSpinBox->setMinimum( 0 );
   mRadiusSpinBox->setPrefix( tr( "Radius of the circle: " ) );
@@ -240,7 +236,6 @@ void QgsMapToolCircle2TangentsPoint::deleteRadiusSpinBox()
 {
   if ( mRadiusSpinBox )
   {
-    QgisApp::instance()->statusBarIface()->removeWidget( mRadiusSpinBox );
     delete mRadiusSpinBox;
     mRadiusSpinBox = nullptr;
   }
@@ -251,10 +246,7 @@ void QgsMapToolCircle2TangentsPoint::radiusSpinBoxChanged( int radius )
   mRadius = radius;
   getPossibleCenter( );
 
-  for ( int i = 0; i < mRubberBands.size() ; ++i )
-  {
-    delete mRubberBands.at( i );
-  }
+  qDeleteAll( mRubberBands );
   mRubberBands.clear();
   if ( mTempRubberBand )
   {
diff --git a/src/app/qgsmaptoolcircle2tangentspoint.h b/src/app/qgsmaptoolcircle2tangentspoint.h
index b5e127ffbfd..f39f83916ce 100644
--- a/src/app/qgsmaptoolcircle2tangentspoint.h
+++ b/src/app/qgsmaptoolcircle2tangentspoint.h
@@ -32,7 +32,7 @@ class QgsMapToolCircle2TangentsPoint: public QgsMapToolAddCircle
     ~QgsMapToolCircle2TangentsPoint();
 
     void cadCanvasReleaseEvent( QgsMapMouseEvent *e ) override;
-    void cadCanvasMoveEvent( QgsMapMouseEvent *e );
+    void cadCanvasMoveEvent( QgsMapMouseEvent *e ) override;
 
   public slots:
     void radiusSpinBoxChanged( int radius );