sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-11-04 00:04:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Address review: rename method to be more API compliant

Browse Source
This commit is contained in:
Germán Carrillo 2024-10-15 18:57:03 -05:00 committed by Nyall Dawson
parent 601dae8854
commit d9f340f018
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gui/vector/qgsdiagramproperties.cpp
View File

@ -878,7 +878,7 @@ std::unique_ptr< QgsDiagram > QgsDiagramProperties::createDiagramObject()
std::unique_ptr<QgsDiagramSettings> QgsDiagramProperties::createDiagramSettings()
{
std::unique_ptr< QgsDiagramSettings > ds = std::make_unique< QgsDiagramSettings>();
ds->enabled = enabledDiagram();
ds->enabled = isDiagramEnabled();
ds->font = mDiagramFontButton->currentFont();
ds->opacity = mOpacityWidget->opacity();
@ -1046,7 +1046,7 @@ void QgsDiagramProperties::apply()
QgsSettings settings;
if ( !dockMode() || !settings.value( QStringLiteral( "UI/autoApplyStyling" ), true ).toBool() )
{
if ( enabledDiagram() && 0 == mDiagramAttributesTreeWidget->topLevelItemCount() )
if ( isDiagramEnabled() && 0 == mDiagramAttributesTreeWidget->topLevelItemCount() )
{
QMessageBox::warning( this, tr( "Diagrams: No attributes added." ),
tr( "You did not add any attributes to this diagram layer. Please specify the attributes to visualize on the diagrams or disable diagrams." ) );
@ -1325,7 +1325,7 @@ void QgsDiagramProperties::setDiagramEnabled( bool enabled )
mEnableDiagramCheckBox->setChecked( enabled );
}
bool QgsDiagramProperties::enabledDiagram() const
bool QgsDiagramProperties::isDiagramEnabled() const
{
return mEnableDiagramCheckBox->isChecked();
}

4
src/gui/vector/qgsdiagramproperties.h
View File

@ -209,7 +209,7 @@ class GUI_EXPORT QgsDiagramProperties : public QgsPanelWidget, private Ui::QgsDi
/**
* Sets widgets to reflect the \a enabled status of the diagram.
* @param enabled Whether the diagram is enabled or not.
* \param enabled Whether the diagram is enabled or not.
*/
void setDiagramEnabled( const bool enabled );
@ -217,7 +217,7 @@ class GUI_EXPORT QgsDiagramProperties : public QgsPanelWidget, private Ui::QgsDi
* Returns whether the current diagram should be enabled or not,
* according to changes in the corresponding widgets.
*/
bool enabledDiagram() const;
bool isDiagramEnabled() const;
friend class QgsStackedDiagramProperties;
friend class QgsStackedDiagramPropertiesDialog;