sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-12 00:02:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes slow update in field calculator

Browse Source 
by blocking the vector signals ...
... and emitting dataChanged at
the end.

I'm a bit worried of side effects,
but I can't see any other solution.

The root of the issue here is that
for each changed field/row an attribute
valueChanged signal is emitted, and the
QgsVectorLayerCache::featureAtId
loads the feature again.
This commit is contained in:
Alessandro Pasotti 2018-10-12 22:13:33 +02:00
parent 42ea216478
commit d79e3adf72
1 changed files with 147 additions and 139 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/app/qgsfieldcalculator.cpp
View File

@ -164,7 +164,13 @@ void QgsFieldCalculator::accept()
builder->saveToRecent( QStringLiteral( "fieldcalc" ) );
if ( ! mVectorLayer )
{
return;
}
else // Need a scope for the blocker let's keep the else for clarity
{
QgsSignalBlocker<QgsVectorLayer> vectorBlocker( mVectorLayer );
// Set up QgsDistanceArea each time we (re-)calculate
QgsDistanceArea myDa;
@ -323,9 +329,11 @@ void QgsFieldCalculator::accept()
mVectorLayer->destroyEditCommand();
return;
}
mVectorLayer->endEditCommand();
}
}
// Vector signals unlocked! Tell the world that the layer has changed
mVectorLayer->dataChanged();
QDialog::accept();
}