From d6ca28463478bdfda8349a45ee660c7089b8ab15 Mon Sep 17 00:00:00 2001
From: Matthias Kuhn <matthias@opengis.ch>
Date: Thu, 31 Oct 2019 08:40:40 +0100
Subject: [PATCH] Avoid type conversion for QCOMPARE

---
 tests/src/core/testqgsdxfexport.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/src/core/testqgsdxfexport.cpp b/tests/src/core/testqgsdxfexport.cpp
index 31b030a90a7..9372759cb06 100644
--- a/tests/src/core/testqgsdxfexport.cpp
+++ b/tests/src/core/testqgsdxfexport.cpp
@@ -153,7 +153,7 @@ void TestQgsDxfExport::testPoints()
 
   QString file = getTempFileName( "point_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   // reload and compare
@@ -181,7 +181,7 @@ void TestQgsDxfExport::testLines()
 
   QString file = getTempFileName( "line_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   // reload and compare
@@ -209,7 +209,7 @@ void TestQgsDxfExport::testPolygons()
 
   QString file = getTempFileName( "polygon_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   // reload and compare
@@ -242,7 +242,7 @@ void TestQgsDxfExport::testMultiSurface()
 
   QString file = getTempFileName( "multisurface_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   // reload and compare
@@ -295,7 +295,7 @@ void TestQgsDxfExport::testMTextEscapeSpaces()
 
   QString file = getTempFileName( "mtext_escape_spaces" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
   QVERIFY( fileContainsText( file, "\\fQGIS Vera Sans|i0|b1;\\H3.81136;A\\~text\\~with\\~spaces" ) );
 }
@@ -331,7 +331,7 @@ void TestQgsDxfExport::testText()
 
   QString file = getTempFileName( "text_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
 
@@ -451,7 +451,7 @@ void TestQgsDxfExport::testGeometryGeneratorExport()
 
   QString file = getTempFileName( "geometry_generator_dxf" );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   QVERIFY( fileContainsText( file, "HATCH" ) );
@@ -484,7 +484,7 @@ void TestQgsDxfExport::testCurveExport()
 
   QString file = getTempFileName( wktType );
   QFile dxfFile( file );
-  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), 0 );
+  QCOMPARE( d.writeToFile( &dxfFile, QStringLiteral( "CP1252" ) ), QgsDxfExport::Success );
   dxfFile.close();
 
   QVERIFY( fileContainsText( file, dxfText ) );