From d4a3cd53d210677bda7f065dc2f75f2f38a705cf Mon Sep 17 00:00:00 2001 From: Mathieu Pellerin Date: Tue, 9 Apr 2024 11:04:42 +0700 Subject: [PATCH] [symbology] Fix a bunch of SVGs missing opacity parameters and previewing badly on dark themes --- images/svg/gpsicons/anchor.svg | 2 +- images/svg/gpsicons/bank.svg | 2 +- images/svg/gpsicons/boat.svg | 4 +- images/svg/gpsicons/camera.svg | 4 +- images/svg/gpsicons/car.svg | 6 +- images/svg/gpsicons/city_building.svg | 2 +- images/svg/gpsicons/city_large.svg | 2 +- images/svg/gpsicons/city_medium.svg | 2 +- images/svg/gpsicons/city_small.svg | 2 +- images/svg/gpsicons/conveneince.svg | 2 +- images/svg/gpsicons/couple.svg | 8 +-- images/svg/gpsicons/cross.svg | 4 +- images/svg/gpsicons/deer.svg | 4 +- images/svg/gpsicons/dollar.svg | 2 +- images/svg/gpsicons/fish.svg | 3 +- images/svg/gpsicons/flag.svg | 4 +- images/svg/gpsicons/food.svg | 4 +- images/svg/gpsicons/gas.svg | 2 +- images/svg/gpsicons/golf.svg | 4 +- images/svg/gpsicons/h.svg | 4 +- images/svg/gpsicons/house.svg | 10 ++-- images/svg/gpsicons/parachute.svg | 4 +- images/svg/gpsicons/parking.svg | 4 +- images/svg/gpsicons/phone.svg | 6 +- images/svg/gpsicons/plane.svg | 2 +- images/svg/gpsicons/point.svg | 2 +- images/svg/gpsicons/question.svg | 6 +- images/svg/gpsicons/shipwreck.svg | 4 +- images/svg/gpsicons/skier.svg | 4 +- images/svg/gpsicons/skull.svg | 4 +- images/svg/gpsicons/swimmer.svg | 6 +- images/svg/gpsicons/table.svg | 2 +- images/svg/gpsicons/teepee.svg | 4 +- images/svg/gpsicons/tree.svg | 2 +- images/svg/gpsicons/walker.svg | 2 +- images/svg/gpsicons/waypoint.svg | 2 +- images/svg/sport/sport_soccer.svg | 66 +--------------------- images/svg/wind_roses/WindRose_01.svg | 2 +- images/svg/wind_roses/WindRose_02.svg | 2 +- tests/src/python/test_selective_masking.py | 2 + 40 files changed, 72 insertions(+), 131 deletions(-) diff --git a/images/svg/gpsicons/anchor.svg b/images/svg/gpsicons/anchor.svg index cd060dc39cf..cd3bb05276c 100644 --- a/images/svg/gpsicons/anchor.svg +++ b/images/svg/gpsicons/anchor.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/bank.svg b/images/svg/gpsicons/bank.svg index 35a1949cd74..cd4aa8a34ea 100644 --- a/images/svg/gpsicons/bank.svg +++ b/images/svg/gpsicons/bank.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/boat.svg b/images/svg/gpsicons/boat.svg index 8b2f74beee2..266314cdbb5 100644 --- a/images/svg/gpsicons/boat.svg +++ b/images/svg/gpsicons/boat.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/camera.svg b/images/svg/gpsicons/camera.svg index 301c1bd32ba..52170ab9092 100644 --- a/images/svg/gpsicons/camera.svg +++ b/images/svg/gpsicons/camera.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/car.svg b/images/svg/gpsicons/car.svg index c25260e5c9c..e14e06115c9 100644 --- a/images/svg/gpsicons/car.svg +++ b/images/svg/gpsicons/car.svg @@ -1,5 +1,5 @@ - - - + + + diff --git a/images/svg/gpsicons/city_building.svg b/images/svg/gpsicons/city_building.svg index e910580d9b4..af9bff3769c 100644 --- a/images/svg/gpsicons/city_building.svg +++ b/images/svg/gpsicons/city_building.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/city_large.svg b/images/svg/gpsicons/city_large.svg index 26ed6b23afd..38052cee6cf 100644 --- a/images/svg/gpsicons/city_large.svg +++ b/images/svg/gpsicons/city_large.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/city_medium.svg b/images/svg/gpsicons/city_medium.svg index 7a9662145ea..5781ab9e848 100644 --- a/images/svg/gpsicons/city_medium.svg +++ b/images/svg/gpsicons/city_medium.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/city_small.svg b/images/svg/gpsicons/city_small.svg index 6db6d367bf0..7707ba10ac6 100644 --- a/images/svg/gpsicons/city_small.svg +++ b/images/svg/gpsicons/city_small.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/conveneince.svg b/images/svg/gpsicons/conveneince.svg index 609b2d7f42a..a43c23daa1d 100644 --- a/images/svg/gpsicons/conveneince.svg +++ b/images/svg/gpsicons/conveneince.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/couple.svg b/images/svg/gpsicons/couple.svg index e9bbe22cea9..8bf0cf5a466 100644 --- a/images/svg/gpsicons/couple.svg +++ b/images/svg/gpsicons/couple.svg @@ -1,6 +1,6 @@ - - - - + + + + diff --git a/images/svg/gpsicons/cross.svg b/images/svg/gpsicons/cross.svg index e4fa4060046..21011fc32f1 100644 --- a/images/svg/gpsicons/cross.svg +++ b/images/svg/gpsicons/cross.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/deer.svg b/images/svg/gpsicons/deer.svg index 9e7c35708fa..f7f337a54cc 100644 --- a/images/svg/gpsicons/deer.svg +++ b/images/svg/gpsicons/deer.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/dollar.svg b/images/svg/gpsicons/dollar.svg index 89d523ec3da..870aa946fed 100644 --- a/images/svg/gpsicons/dollar.svg +++ b/images/svg/gpsicons/dollar.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/fish.svg b/images/svg/gpsicons/fish.svg index 8de6bf47e56..e23707d0273 100644 --- a/images/svg/gpsicons/fish.svg +++ b/images/svg/gpsicons/fish.svg @@ -1,4 +1,3 @@ - - + diff --git a/images/svg/gpsicons/flag.svg b/images/svg/gpsicons/flag.svg index c05b9a3e592..f906b75438b 100644 --- a/images/svg/gpsicons/flag.svg +++ b/images/svg/gpsicons/flag.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/food.svg b/images/svg/gpsicons/food.svg index 2c91f3a239a..5097a592888 100644 --- a/images/svg/gpsicons/food.svg +++ b/images/svg/gpsicons/food.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/gas.svg b/images/svg/gpsicons/gas.svg index 28a9044fd36..7219a2ff9ae 100644 --- a/images/svg/gpsicons/gas.svg +++ b/images/svg/gpsicons/gas.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/golf.svg b/images/svg/gpsicons/golf.svg index 64b5d98d5a6..d23fa93aac7 100644 --- a/images/svg/gpsicons/golf.svg +++ b/images/svg/gpsicons/golf.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/h.svg b/images/svg/gpsicons/h.svg index d8dc0966a95..0da427f26a7 100644 --- a/images/svg/gpsicons/h.svg +++ b/images/svg/gpsicons/h.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/house.svg b/images/svg/gpsicons/house.svg index bf45168bb7a..ffe5aafb439 100644 --- a/images/svg/gpsicons/house.svg +++ b/images/svg/gpsicons/house.svg @@ -1,7 +1,7 @@ - - - - - + + + + + diff --git a/images/svg/gpsicons/parachute.svg b/images/svg/gpsicons/parachute.svg index 8a6a7eaf6b7..ca71b6728c6 100644 --- a/images/svg/gpsicons/parachute.svg +++ b/images/svg/gpsicons/parachute.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/parking.svg b/images/svg/gpsicons/parking.svg index 1c310ba22f0..08b5c4a0f8e 100644 --- a/images/svg/gpsicons/parking.svg +++ b/images/svg/gpsicons/parking.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/phone.svg b/images/svg/gpsicons/phone.svg index 02dcae01f87..39994e64716 100644 --- a/images/svg/gpsicons/phone.svg +++ b/images/svg/gpsicons/phone.svg @@ -1,5 +1,5 @@ - - - + + + diff --git a/images/svg/gpsicons/plane.svg b/images/svg/gpsicons/plane.svg index 828294f3e52..24e54283aa9 100644 --- a/images/svg/gpsicons/plane.svg +++ b/images/svg/gpsicons/plane.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/point.svg b/images/svg/gpsicons/point.svg index e156ec8232b..4d4118b7a98 100644 --- a/images/svg/gpsicons/point.svg +++ b/images/svg/gpsicons/point.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/question.svg b/images/svg/gpsicons/question.svg index 9d7c0d9ed26..32e15a3afdb 100644 --- a/images/svg/gpsicons/question.svg +++ b/images/svg/gpsicons/question.svg @@ -1,5 +1,5 @@ - - - + + + diff --git a/images/svg/gpsicons/shipwreck.svg b/images/svg/gpsicons/shipwreck.svg index 3afdedb121c..b62684f9d1d 100644 --- a/images/svg/gpsicons/shipwreck.svg +++ b/images/svg/gpsicons/shipwreck.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/skier.svg b/images/svg/gpsicons/skier.svg index 9ff1bb92a67..482a1925846 100644 --- a/images/svg/gpsicons/skier.svg +++ b/images/svg/gpsicons/skier.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/skull.svg b/images/svg/gpsicons/skull.svg index dff3c2b521e..0020e86cd23 100644 --- a/images/svg/gpsicons/skull.svg +++ b/images/svg/gpsicons/skull.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/swimmer.svg b/images/svg/gpsicons/swimmer.svg index 331935bd7d0..a78d23b88bb 100644 --- a/images/svg/gpsicons/swimmer.svg +++ b/images/svg/gpsicons/swimmer.svg @@ -1,5 +1,5 @@ - - - + + + diff --git a/images/svg/gpsicons/table.svg b/images/svg/gpsicons/table.svg index c11c754883d..d6f0bfc9c79 100644 --- a/images/svg/gpsicons/table.svg +++ b/images/svg/gpsicons/table.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/teepee.svg b/images/svg/gpsicons/teepee.svg index 25cd2e4d938..34dc1e258a4 100644 --- a/images/svg/gpsicons/teepee.svg +++ b/images/svg/gpsicons/teepee.svg @@ -1,4 +1,4 @@ - - + + diff --git a/images/svg/gpsicons/tree.svg b/images/svg/gpsicons/tree.svg index a14f18916b4..659651be9af 100644 --- a/images/svg/gpsicons/tree.svg +++ b/images/svg/gpsicons/tree.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/walker.svg b/images/svg/gpsicons/walker.svg index b42d62c38c0..8672e748548 100644 --- a/images/svg/gpsicons/walker.svg +++ b/images/svg/gpsicons/walker.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/gpsicons/waypoint.svg b/images/svg/gpsicons/waypoint.svg index 0186fb59a18..aa2be832ca6 100644 --- a/images/svg/gpsicons/waypoint.svg +++ b/images/svg/gpsicons/waypoint.svg @@ -1,3 +1,3 @@ - + diff --git a/images/svg/sport/sport_soccer.svg b/images/svg/sport/sport_soccer.svg index ccbbb6e436b..eb331b24dcd 100644 --- a/images/svg/sport/sport_soccer.svg +++ b/images/svg/sport/sport_soccer.svg @@ -1,64 +1,4 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + diff --git a/images/svg/wind_roses/WindRose_01.svg b/images/svg/wind_roses/WindRose_01.svg index 2b614aabafd..b1611d02341 100644 --- a/images/svg/wind_roses/WindRose_01.svg +++ b/images/svg/wind_roses/WindRose_01.svg @@ -4,7 +4,7 @@ clean - - diff --git a/tests/src/python/test_selective_masking.py b/tests/src/python/test_selective_masking.py index b847b37ad36..0531dca8cc5 100644 --- a/tests/src/python/test_selective_masking.py +++ b/tests/src/python/test_selective_masking.py @@ -1326,6 +1326,8 @@ class TestSelectiveMasking(QgisTestCase): sl = QgsSvgMarkerSymbolLayer(svgPath, 5) sl.setFillColor(QColor("blue")) + sl.setStrokeColor(QColor("white")) + sl.setStrokeWidth(0) p = QgsMarkerSymbol() p.changeSymbolLayer(0, sl)