From c735ee32f9baa660394c0a4d87dda6c045d48969 Mon Sep 17 00:00:00 2001 From: Tom Christian Date: Mon, 29 Sep 2025 13:13:45 -0700 Subject: [PATCH] feat(#62838): PR feedback --- python/PyQt6/core/auto_generated/stac/qgsstacasset.sip.in | 2 +- python/core/auto_generated/stac/qgsstacasset.sip.in | 2 +- src/core/stac/qgsstacasset.cpp | 1 + src/core/stac/qgsstacasset.h | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/python/PyQt6/core/auto_generated/stac/qgsstacasset.sip.in b/python/PyQt6/core/auto_generated/stac/qgsstacasset.sip.in index b260a6cd591..59b96bb374a 100644 --- a/python/PyQt6/core/auto_generated/stac/qgsstacasset.sip.in +++ b/python/PyQt6/core/auto_generated/stac/qgsstacasset.sip.in @@ -86,7 +86,7 @@ COPC, empty auth configuration Returns a uri for the asset if it is a cloud optimized file like COG or COPC -.. versionadded:: 3.42 +.. versionadded:: 4.0 %End QString toHtml( const QString &assetId ) const; diff --git a/python/core/auto_generated/stac/qgsstacasset.sip.in b/python/core/auto_generated/stac/qgsstacasset.sip.in index b260a6cd591..59b96bb374a 100644 --- a/python/core/auto_generated/stac/qgsstacasset.sip.in +++ b/python/core/auto_generated/stac/qgsstacasset.sip.in @@ -86,7 +86,7 @@ COPC, empty auth configuration Returns a uri for the asset if it is a cloud optimized file like COG or COPC -.. versionadded:: 3.42 +.. versionadded:: 4.0 %End QString toHtml( const QString &assetId ) const; diff --git a/src/core/stac/qgsstacasset.cpp b/src/core/stac/qgsstacasset.cpp index 74e63a5aa83..5557b29932b 100644 --- a/src/core/stac/qgsstacasset.cpp +++ b/src/core/stac/qgsstacasset.cpp @@ -137,6 +137,7 @@ QgsMimeDataUtils::Uri QgsStacAsset::uri( const QString &authcfg ) const } else if ( href().startsWith( QLatin1String( "s3://" ), Qt::CaseInsensitive ) ) { + // Remove the s3:// protocol prefix for compatibility with GDAL's /vsis3 uri.uri = QStringLiteral( "ZARR:\"/vsis3/%1\"" ).arg( href().mid( 5 ) ); } else diff --git a/src/core/stac/qgsstacasset.h b/src/core/stac/qgsstacasset.h index a6790872dd9..186e5c7abaf 100644 --- a/src/core/stac/qgsstacasset.h +++ b/src/core/stac/qgsstacasset.h @@ -80,7 +80,7 @@ class CORE_EXPORT QgsStacAsset /** * Returns a uri for the asset if it is a cloud optimized file like COG or COPC - * \since QGIS 3.42 + * \since QGIS 4.0 */ QgsMimeDataUtils::Uri uri( const QString &authcfg ) const;