From c44fa1da5cf2a8b5fbc0cc6f3f682dfa6f8fc94d Mon Sep 17 00:00:00 2001
From: Sandro Mani <manisandro@gmail.com>
Date: Thu, 12 Oct 2017 14:45:56 +0200
Subject: [PATCH] [Geometry checker] Finish gap check test

---
 .../geometry_checker/testqgsgeometrychecks.cpp |  11 +++++++++--
 tests/testdata/geometry_checker/gap_layer.dbf  | Bin 121 -> 132 bytes
 tests/testdata/geometry_checker/gap_layer.shp  | Bin 860 -> 1012 bytes
 tests/testdata/geometry_checker/gap_layer.shx  | Bin 140 -> 148 bytes
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/tests/src/geometry_checker/testqgsgeometrychecks.cpp b/tests/src/geometry_checker/testqgsgeometrychecks.cpp
index e78be0b119d..ae2123f700a 100644
--- a/tests/src/geometry_checker/testqgsgeometrychecks.cpp
+++ b/tests/src/geometry_checker/testqgsgeometrychecks.cpp
@@ -26,6 +26,7 @@
 #include "qgsgeometrydegeneratepolygoncheck.h"
 #include "qgsgeometryduplicatecheck.h"
 #include "qgsgeometryduplicatenodescheck.h"
+#include "qgsgeometrygapcheck.h"
 #include "qgsgeometryholecheck.h"
 #include "qgsgeometrylineintersectioncheck.h"
 #include "qgsgeometrylinelayerintersectioncheck.h"
@@ -38,7 +39,6 @@
 #include "qgsgeometryselfintersectioncheck.h"
 #include "qgsgeometrysliverpolygoncheck.h"
 
-#include "qgsgeometrygapcheck.h"
 #include "qgsgeometrytypecheck.h"
 
 
@@ -230,9 +230,16 @@ void TestQgsGeometryChecks::testGapCheck()
   QList<QgsGeometryCheckError *> checkErrors;
   QStringList messages;
 
-  QgsGeometryGapCheck( context, 0.001 ).collectErrors( checkErrors, messages );
+  QgsGeometryGapCheck( context, 0.01 ).collectErrors( checkErrors, messages );
   listErrors( checkErrors, messages );
 
+  QCOMPARE( checkErrors.size(), 5 );
+  QVERIFY( searchCheckError( checkErrors, "", -1, QgsPointXY( 0.2924, -0.8798 ), QgsVertexId(), 0.0027 ) == 1 );
+  QVERIFY( searchCheckError( checkErrors, "", -1, QgsPointXY( 0.4238, -0.7479 ), QgsVertexId(), 0.0071 ) == 1 );
+  QVERIFY( searchCheckError( checkErrors, "", -1, QgsPointXY( 0.0094, -0.4448 ), QgsVertexId(), 0.0033 ) == 1 );
+  QVERIFY( searchCheckError( checkErrors, "", -1, QgsPointXY( 0.2939, -0.4694 ), QgsVertexId(), 0.0053 ) == 1 );
+  QVERIFY( searchCheckError( checkErrors, "", -1, QgsPointXY( 0.6284, -0.3641 ), QgsVertexId(), 0.0018 ) == 1 );
+
   cleanupTestContext( context );
 }
 
diff --git a/tests/testdata/geometry_checker/gap_layer.dbf b/tests/testdata/geometry_checker/gap_layer.dbf
index 7ab5f984e77b13c4f227b82b131c401ee27f273d..98c969c0b667c0a0b5b00ec0dfabec089df7a663 100644
GIT binary patch
literal 132
zcmZRMXP07QU|?`$;0BVIATtFn<_BVN!MP9yuL2wxz*!202&NH&X^dc+Aeg3700nyr
A(EtDd

literal 121
ocmZQB<&<G%U|?`$;0BVIATtFn<_BVN!MP9yuYwjFkiwJ#0MRK64*&oF

diff --git a/tests/testdata/geometry_checker/gap_layer.shp b/tests/testdata/geometry_checker/gap_layer.shp
index 8c577b48a47357fde15d38945a288926914b3f39..bc0fb7649d74d8e28bdca870a52426243dcdca68 100644
GIT binary patch
literal 1012
zcmZQzQ0HR63K)OAU}j)o1<K7~ZhFELaB{z3W0kB@;D`NUA{njw;$PUC%=7hm<a~ZV
zR_&;Qj6kjf$gGB`%)Uairr0ltncyF|>)w7d{@<o)yPm+!0x1Nk1B0?Wu3u#f;c_sw
z6JEUwGhn%}U+z=#R8GamaI;`$Un$wOAavcG{S0XOfo3uRu?IFkX;kfxTc~#kZWqWM
zY+y$K33PMpOftGEXYChQ7`m&r`^kQoURd}<utXpCOy0Er>#2*yMj9XX!@`eAhga_U
z+UMBZ1q^A12(Z7QX2Z;?urt}P&h(}|%ugV9aX{ULZZ89xyU@eqh{JnJhNl<o=Rm_A
zX7-8#Mv2nJFZQ3fqwC*VbKXA6$7x>P*4O)OVzy`5yI-{5pcyo!_1}98e*&Gs0>t2W
zJ<}|5q+#&|xY~|WY&Iv3Jhq3KjU2D&=EC&$l;)+M^?0)%-CZ!V4t+Xk#BTK-!(Bi(
zfPxMjuP{Ht)WY<_{EQs0FgcjoGh9x3+4pbRYYB<OZf$z8A7&OzFM4`Aq#7pfTmH~q
z!eWuz&E?PbqnihG6DSFR-38MNvkR7oU}+hjyI^`@dB!40;lQ(sC-yg{-nLTIyAIDo
TFtcE0@3Ji1_U+zt40izli>s49

literal 860
zcmZQzQ0HR63K-YDU}j)o1<GB_p4JyswR*p|<UNJlvVHdPMhu0Mt4r+#DyIn5FFIzA
zRXeI6Baj;bGAphAvkwd7%KglH{;RaVK45<|xF#ei(ry2dc)|H9_m9|v6mmfIingcs
zwg=7FZ&Tc>yRhq!eS2DN|CWRm`@4RgIqKqi*dAsUOfT!J5QoRSE&CrwRa#fH9)X(;
zv+GWxeRN{!l>LdZD{sk%9I{slofX3<J8A#7!aaXPtd7{D+Xr+86A*hKhe2jC-<RWc
z2kljFPb;w6zG6Qt3_$K?gSxx>VCuvJEGzfJ)WX7VhHHI@jnrZLfRJ6~8!oSe>xG&1
z=#8bKvgT3yw1W@9VKn;=J2*_x%>!Bkj2Q+8kh{Kl`-1I)#SJVx!;AKV!wBRqkU9{U
z|HA?telR(hT3Gm8ZhNjf?M?$co?&L&mg|81jIJMOBnuFO!{^wFSg_ueC$bcg(@56g
zscfr5kAdSA7Cr@$X;D9yRqcn#S!rdYw2CC#_mrL~`lo*kp1vNqd^3J`cb`4F+34;@
zHxKA0ke9*XvsrN(IIMMfdckSp>h@z`yJyd<1gBl(@PVm?$-&e{g_(l=@JC@YIDNs)
Sl9t{IP6M{Dg2C~It{(vJAW%U7

diff --git a/tests/testdata/geometry_checker/gap_layer.shx b/tests/testdata/geometry_checker/gap_layer.shx
index e193f4cdee43508fb29ff997390f96fff201c8d3..b911768550e6dcc13f718f40e790fe9ef724d558 100644
GIT binary patch
literal 148
zcmZQzQ0HR64!mA4Gcd3M<>oLqJz)wsxnHocN>(ZG!+tT5jMjbeFYHa``T9I^KEEHk
mb`((~AkP7a%YfJehz|jA1Oo%39FTSZ(n&xXD9*SJL<0bYLKIp6

literal 140
zcmZQzQ0HR64%}WaGcd3M<t}DV>kFz{z295%o<eTfKKpnhhQi6!rS<}qQ-tal9ka)-
e9Yxd#$cq5tJ|Ol0;#)xMz`(#L2jMejf%pK(SrX*{