From bb4962ee30e20a1e318157fc60a9723992cd2f2c Mon Sep 17 00:00:00 2001 From: Nyall Dawson Date: Fri, 21 Feb 2025 11:04:35 +1000 Subject: [PATCH] Revert "Only emit cameraChanged() on frame start" This reverts commit 0f3129b7a4d420471dd4eaaecbee26165f49a3cf. --- src/3d/qgscameracontroller.cpp | 8 +------- src/3d/qgscameracontroller.h | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/3d/qgscameracontroller.cpp b/src/3d/qgscameracontroller.cpp index d13debfc5ea..b889a069a4e 100644 --- a/src/3d/qgscameracontroller.cpp +++ b/src/3d/qgscameracontroller.cpp @@ -161,12 +161,6 @@ void QgsCameraController::zoomCameraAroundPivot( const QVector3D &oldCameraPosit void QgsCameraController::frameTriggered( float dt ) { Q_UNUSED( dt ) - - if ( mCameraChanged ) - { - emit cameraChanged(); - mCameraChanged = false; - } } void QgsCameraController::resetView( float distance ) @@ -288,7 +282,7 @@ void QgsCameraController::updateCameraFromPose() if ( mCamera ) mCameraPose.updateCamera( mCamera ); - mCameraChanged = true; + emit cameraChanged(); } void QgsCameraController::moveCameraPositionBy( const QVector3D &posDiff ) diff --git a/src/3d/qgscameracontroller.h b/src/3d/qgscameracontroller.h index 08830805c12..6bb158e7831 100644 --- a/src/3d/qgscameracontroller.h +++ b/src/3d/qgscameracontroller.h @@ -385,9 +385,6 @@ class _3D_EXPORT QgsCameraController : public QObject // 3D world's origin in map coordinates QgsVector3D mOrigin; - //! Did camera change since last frame? Need to know if we should emit cameraChanged(). - bool mCameraChanged = false; - // To test the cameracontroller friend class TestQgs3DRendering; friend class TestQgs3DCameraController;