From b23a972be23bf84b48848c030e54854e4e5d6135 Mon Sep 17 00:00:00 2001
From: Julien Cabieces <julien.cabieces@oslandia.com>
Date: Mon, 28 Oct 2019 11:43:07 +0100
Subject: [PATCH] fix bad use of getSelectedFeatures

---
 src/gui/qgsrelationeditorwidget.cpp | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/gui/qgsrelationeditorwidget.cpp b/src/gui/qgsrelationeditorwidget.cpp
index b3b1b9766ab..c5deeffd702 100644
--- a/src/gui/qgsrelationeditorwidget.cpp
+++ b/src/gui/qgsrelationeditorwidget.cpp
@@ -49,12 +49,9 @@ class QgsFilteredSelectionManager : public QgsVectorLayerSelectionManager
       : QgsVectorLayerSelectionManager( layer, parent )
       , mRequest( request )
     {
-      QgsFeature feature;
-      QgsFeatureIterator it = layer->getSelectedFeatures( mRequest );
-      while ( it.nextFeature( feature ) )
-      {
-        mSelectedFeatureIds << feature.id();
-      }
+      for ( auto fid : layer->selectedFeatureIds() )
+        if ( mRequest.acceptFeature( layer->getFeature( fid ) ) )
+          mSelectedFeatureIds << fid;
 
       connect( layer, &QgsVectorLayer::selectionChanged, this, &QgsFilteredSelectionManager::onSelectionChanged );
     }