From aea21306edc1ac6c597de573a0d6341dcadee661 Mon Sep 17 00:00:00 2001 From: "arnaud.morvan@camptocamp.com" Date: Sat, 29 Apr 2017 23:06:48 +0200 Subject: [PATCH] Fix new bookmark query. Fix #16465 QSqlQuery was returning an error : wrong parameters count. It seems that bindValue was having no effect (no bounded values). Using prepare after construction seems to solve the problem. --- src/app/qgsbookmarks.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/qgsbookmarks.cpp b/src/app/qgsbookmarks.cpp index 5e243ab3e0f..0719eea31ac 100644 --- a/src/app/qgsbookmarks.cpp +++ b/src/app/qgsbookmarks.cpp @@ -139,9 +139,9 @@ void QgsBookmarks::addClicked() QgsMapCanvas *canvas = QgisApp::instance()->mapCanvas(); Q_ASSERT( canvas ); - QSqlQuery query( "INSERT INTO tbl_bookmarks(bookmark_id,name,project_name,xmin,ymin,xmax,ymax,projection_srid)" - " VALUES (NULL,:name,:project_name,:xmin,:xmax,:ymin,:ymax,:projection_srid)", - mQgisModel->database() ); + QSqlQuery query( mQgisModel->database() ); + query.prepare( "INSERT INTO tbl_bookmarks(bookmark_id,name,project_name,xmin,ymin,xmax,ymax,projection_srid)" + " VALUES (NULL,:name,:project_name,:xmin,:xmax,:ymin,:ymax,:projection_srid)" ); QString projStr( QLatin1String( "" ) ); if ( QgsProject::instance() )