From a45a82e8d744c353e23effc24c5e0ce0df3042a7 Mon Sep 17 00:00:00 2001
From: Alessandro Pasotti <elpaso@itopen.it>
Date: Mon, 10 Jun 2019 15:58:03 +0200
Subject: [PATCH] Less autos more consts

---
 src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp b/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp
index 2e29aaab9b3..240264ffdb1 100644
--- a/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp
+++ b/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp
@@ -276,13 +276,14 @@ bool QgsValueRelationFieldFormatter::expressionIsUsable( const QString &expressi
 
 QgsVectorLayer *QgsValueRelationFieldFormatter::resolveLayer( const QVariantMap &config )
 {
-  auto layer { QgsProject::instance()->mapLayer<QgsVectorLayer *>( config.value( QStringLiteral( "Layer" ) ).toString() ) };
+  QgsVectorLayer *layer { QgsProject::instance()->mapLayer<QgsVectorLayer *>( config.value( QStringLiteral( "Layer" ) ).toString() ) };
   if ( ! layer )
   {
     const auto name { config.value( QStringLiteral( "LayerName" ) ).toString() };
     if ( ! name.isEmpty() )
     {
-      for ( QgsMapLayer *l : QgsProject::instance()->mapLayers( true ) )
+      const auto constLayers { QgsProject::instance()->mapLayers( true ) };
+      for ( QgsMapLayer *l : constLayers )
       {
         QgsVectorLayer *vl { qobject_cast<QgsVectorLayer *>( l ) };
         if ( vl && vl->name() == name )