sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-02-22 00:06:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix leak when creating empty spatialite layers

Browse Source
This commit is contained in:
Nyall Dawson 2025-02-17 12:29:02 +10:00
parent aa04760f80
commit 91c796eb05
No known key found for this signature in database
GPG Key ID: 4C61673F0BF197FC
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/providers/spatialite/qgsspatialiteprovider.cpp
View File

@ -365,7 +365,7 @@ Qgis::VectorExportResult QgsSpatiaLiteProvider::createEmptyLayer( const QString
dsUri.setDataSource( QString(), tableName, geometryColumn, QString(), primaryKey );
QgsDataProvider::ProviderOptions providerOptions;
QgsSpatiaLiteProvider *provider = new QgsSpatiaLiteProvider( dsUri.uri(), providerOptions );
auto provider = std::make_unique< QgsSpatiaLiteProvider >( dsUri.uri(), providerOptions );
if ( !provider->isValid() )
{
QgsDebugError( "The layer " + tableName + " just created is not valid or not supported by the provider." );
@ -373,7 +373,6 @@ Qgis::VectorExportResult QgsSpatiaLiteProvider::createEmptyLayer( const QString
*errorMessage = QObject::tr( "loading of the layer %1 failed" )
.arg( tableName );
delete provider;
return Qgis::VectorExportResult::ErrorInvalidLayer;
}
@ -408,7 +407,6 @@ Qgis::VectorExportResult QgsSpatiaLiteProvider::createEmptyLayer( const QString
*errorMessage = QObject::tr( "unsupported type for field %1" )
.arg( fld.name() );
delete provider;
return Qgis::VectorExportResult::ErrorAttributeTypeUnsupported;
}
@ -427,7 +425,6 @@ Qgis::VectorExportResult QgsSpatiaLiteProvider::createEmptyLayer( const QString
if ( errorMessage )
*errorMessage = QObject::tr( "creation of fields failed" );
delete provider;
return Qgis::VectorExportResult::ErrorAttributeCreationFailed;
}