Address review

This commit is contained in:
Mathieu Pellerin 2025-01-26 17:41:49 +07:00 committed by Nyall Dawson
parent c62e2d2096
commit 8f9024bcb6
3 changed files with 11 additions and 6 deletions

View File

@ -1,5 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="24" height="24" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path d="m20.43 9.33h-4.19l-1.24 5.27h3.88v1.74h-4.32l-1.23 5.01h-1.63l1.23-5.01h-3.4l-1.23 5.01h-1.63l1.23-5.01h-3.75v-1.74h4.19l1.24-5.27h-3.88v-1.74h4.32l1.32-5.44h1.63l-1.32 5.44h3.4l1.32-5.44h1.63l-1.32 5.44h3.75zm-5.78-0.0258h-3.45l-1.26 5.32h3.45z" fill="#505050" stroke="#c8c8c8" stroke-width="2.5"/>
<path d="m20.43 9.33h-4.19l-1.24 5.27h3.88v1.74h-4.32l-1.23 5.01h-1.63l1.23-5.01h-3.4l-1.23 5.01h-1.63l1.23-5.01h-3.75v-1.74h4.19l1.24-5.27h-3.88v-1.74h4.32l1.32-5.44h1.63l-1.32 5.44h3.4l1.32-5.44h1.63l-1.32 5.44h3.75zm-5.78-0.0258h-3.45l-1.26 5.32h3.45z" fill="#505050" stroke="#505050" stroke-width=".3"/>
<path d="m20.43 9.33h-4.19l-1.24 5.27h3.88v1.74h-4.32l-1.23 5.01h-1.63l1.23-5.01h-3.4l-1.23 5.01h-1.63l1.23-5.01h-3.75v-1.74h4.19l1.24-5.27h-3.88v-1.74h4.32l1.32-5.44h1.63l-1.32 5.44h3.4l1.32-5.44h1.63l-1.32 5.44h3.75zm-5.78-0.0258h-3.45l-1.26 5.32h3.45z" fill="param(fill)" fill-opacity="param(fill-opacity)"/>
</svg>

Before

Width:  |  Height:  |  Size: 743 B

After

Width:  |  Height:  |  Size: 437 B

View File

@ -46,7 +46,7 @@ from qgis.PyQt.QtWidgets import (
QApplication,
QShortcut,
)
from qgis.PyQt.QtGui import QDesktopServices, QKeySequence
from qgis.PyQt.QtGui import QDesktopServices, QKeySequence, QColor, QPalette
from qgis.PyQt.QtWidgets import QVBoxLayout, QMessageBox
from qgis.utils import iface
from .console_sci import ShellScintilla
@ -320,7 +320,10 @@ class PythonConsoleWidget(QWidget):
self.toggleCommentEditorButton.setCheckable(False)
self.toggleCommentEditorButton.setEnabled(True)
self.toggleCommentEditorButton.setIcon(
QgsApplication.getThemeIcon("console/iconCommentEditorConsole.svg")
QgsApplication.getThemeIcon(
"console/iconCommentEditorConsole.svg",
self.palette().color(QPalette.WindowText),
),
)
self.toggleCommentEditorButton.setMenuRole(QAction.MenuRole.PreferencesRole)
self.toggleCommentEditorButton.setIconVisibleInMenu(True)

View File

@ -48,7 +48,7 @@ from qgis.PyQt.QtCore import (
Qt,
QUrl,
)
from qgis.PyQt.QtGui import QKeySequence
from qgis.PyQt.QtGui import QKeySequence, QColor, QPalette
from qgis.PyQt.QtNetwork import QNetworkRequest
from qgis.PyQt.QtWidgets import (
QAction,
@ -261,7 +261,10 @@ class Editor(QgsCodeEditorPython):
menu.addSeparator()
toggle_comment_action = QAction(
QgsApplication.getThemeIcon("console/iconCommentEditorConsole.svg"),
QgsApplication.getThemeIcon(
"console/iconCommentEditorConsole.svg",
self.palette().color(QPalette.WindowText),
),
QCoreApplication.translate("PythonConsole", "Toggle Comment"),
menu,
)