From 8b2e1880db5b3ebc26116f23226f15c2402624f3 Mon Sep 17 00:00:00 2001 From: Martin Dobias Date: Wed, 27 Mar 2019 17:22:34 +0100 Subject: [PATCH] [quick] Fix validity condition in QgsQuickFeatureLayerPair The extra condition enforcing that feature's geometry needs to have Z coordinate if also its parent layer has Z coordinates was not doing good job and surprisingly marking also valid geometries as invalid if layer type was PointZ but the geometry had undefined Z value. This caused issues in IdentifyKit not picking up some features. --- src/quickgui/qgsquickfeaturelayerpair.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/quickgui/qgsquickfeaturelayerpair.cpp b/src/quickgui/qgsquickfeaturelayerpair.cpp index 5d329ae5a82..9c67b13eeeb 100644 --- a/src/quickgui/qgsquickfeaturelayerpair.cpp +++ b/src/quickgui/qgsquickfeaturelayerpair.cpp @@ -66,8 +66,5 @@ bool QgsQuickFeatureLayerPair::hasValidGeometry() const if ( mFeature.geometry().type() != mLayer->geometryType() ) return false; - if ( QgsWkbTypes::hasZ( mLayer->wkbType() ) != QgsWkbTypes::hasZ( mFeature.geometry().wkbType() ) ) - return false; - return true; }