sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-01 00:46:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Never assume anything

Browse Source 
because when you do, reality will teach you better
This commit is contained in:
Matthias Kuhn 2019-03-03 00:24:46 +01:00
parent dcc92de5d0
commit 82ca2dd873
No known key found for this signature in database
GPG Key ID: 7A7F1A1C90C3E6A7
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/analysis/vector/geometry_checker/qgsfeaturepool.cpp
View File

@ -38,7 +38,15 @@ QgsFeaturePool::QgsFeaturePool( QgsVectorLayer *layer )
bool QgsFeaturePool::getFeature( QgsFeatureId id, QgsFeature &feature, QgsFeedback *feedback )
{
QgsReadWriteLocker locker( mCacheLock, QgsReadWriteLocker::Read );
// Why is there a write lock acquired here? Weird, we only want to read a feature from the cache, right?
// A method like `QCache::object(const Key &key) const` certainly would not modify its internals.
// Mmmh. What if reality was different?
// If one reads the docs very, very carefully one will find the term "reentrant" in the
// small print of the QCache docs. This is the hint that reality is different.
//
// https://bugreports.qt.io/browse/QTBUG-19794
QgsReadWriteLocker locker( mCacheLock, QgsReadWriteLocker::Write );
QgsFeature *cachedFeature = mFeatureCache.object( id );
if ( cachedFeature )
{