diff --git a/src/providers/wms/qgswmsdataitems.cpp b/src/providers/wms/qgswmsdataitems.cpp index 7d6967b85d4..d51c7b508d7 100644 --- a/src/providers/wms/qgswmsdataitems.cpp +++ b/src/providers/wms/qgswmsdataitems.cpp @@ -96,7 +96,7 @@ QVector QgsWMSConnectionItem::createChildren() // Attention, the name may be empty QgsDebugMsgLevel( QString::number( layerProperty.orderId ) + ' ' + layerProperty.name + ' ' + layerProperty.title, 2 ); QString pathName = layerProperty.name.isEmpty() ? QString::number( layerProperty.orderId ) : layerProperty.name; - QgsDataItem *layer; + QgsDataItem *layer = nullptr; if ( layerProperty.name.isEmpty() ) layer = new QgsWMSLayerCollectionItem( this, layerProperty.title, mPath + '/' + pathName, capabilitiesProperty, uri, layerProperty ); @@ -266,15 +266,13 @@ bool QgsWMSLayerCollectionItem::equal( const QgsDataItem *other ) { return false; } - const QgsWMSLayerCollectionItem *otherCollectionItem = dynamic_cast( other ); + const QgsWMSLayerCollectionItem *otherCollectionItem = qobject_cast( other ); if ( !otherCollectionItem ) { return false; } // Check if the children are not the same then they are not equal - if ( mChildren.isEmpty() & !otherCollectionItem->mChildren.isEmpty() ) - return false; if ( mChildren.size() != otherCollectionItem->mChildren.size() ) return false;