sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-23 00:05:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove outdated comment

Browse Source 
As tested by @3nids, QPrinter::PdfFormat works correctly on OSX
(as of Qt 5.11) and correctly respects "text as text" setting
without forcing conversion to paths.
This commit is contained in:
Nyall Dawson 2018-12-07 08:49:06 +10:00
parent 4f9f5d1cd1
commit 7f5441c957
1 changed files with 0 additions and 7 deletions

7
src/core/layout/qgslayoutexporter.cpp

@ -1026,13 +1026,6 @@ QgsLayoutExporter::ExportResult QgsLayoutExporter::exportToSvg( QgsAbstractLayou
void QgsLayoutExporter::preparePrintAsPdf( QgsLayout *layout, QPrinter &printer, const QString &filePath )
{
printer.setOutputFileName( filePath );
// setOutputFormat MUST come after setOutputFileName, which auto-sets format to QPrinter::PdfFormat.
// [LS] This should be QPrinter::NativeFormat for Mac, otherwise fonts are not embed-able
// and text is not searchable; however, there are several bugs with <= Qt 4.8.5, 5.1.1, 5.2.0:
// https://bugreports.qt.io/browse/QTBUG-10094 - PDF font embedding fails
// https://bugreports.qt.io/browse/QTBUG-33583 - PDF output converts text to outline
// Also an issue with PDF paper size using QPrinter::NativeFormat on Mac (always outputs portrait letter-size)
printer.setOutputFormat( QPrinter::PdfFormat );
updatePrinterPageSize( layout, printer, firstPageToBeExported( layout ) );