From 75fe94f3cf742bfa4c3da0e0f242f182ca1ecc43 Mon Sep 17 00:00:00 2001
From: Nyall Dawson <nyall.dawson@gmail.com>
Date: Mon, 16 Jul 2018 08:05:20 +1000
Subject: [PATCH] Fix missing break, warnings

---
 .../offline_editing/offline_editing_plugin_gui.cpp        | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/plugins/offline_editing/offline_editing_plugin_gui.cpp b/src/plugins/offline_editing/offline_editing_plugin_gui.cpp
index f5aaa749afc..31e6db4122c 100644
--- a/src/plugins/offline_editing/offline_editing_plugin_gui.cpp
+++ b/src/plugins/offline_editing/offline_editing_plugin_gui.cpp
@@ -82,10 +82,9 @@ QVariant QgsSelectLayerTreeModel::data( const QModelIndex &index, int role ) con
                        "please check with your system administrator<br>"
                        "if this WFS layer can be used for offline<br>"
                        "editing." );
-            break;
+
           case Qt::DecorationRole:
-            return QgsApplication::getThemeIcon( "/mIconWarning.svg" );
-            break;
+            return QgsApplication::getThemeIcon( QStringLiteral( "/mIconWarning.svg" ) );
         }
       }
     }
@@ -177,7 +176,9 @@ void QgsOfflineEditingPluginGui::mBrowseButton_clicked()
         mOfflineDataPath = QFileInfo( fileName ).absolutePath();
         mOfflineDataPathLineEdit->setText( fileName );
       }
+      break;
     }
+
     case QgsOfflineEditing::SpatiaLite:
     {
       //SpaciaLite
@@ -197,6 +198,7 @@ void QgsOfflineEditingPluginGui::mBrowseButton_clicked()
         mOfflineDataPath = QFileInfo( fileName ).absolutePath();
         mOfflineDataPathLineEdit->setText( fileName );
       }
+      break;
     }
   }
 }