From 74fd45bbb3a407cd361730349ee563cc51081526 Mon Sep 17 00:00:00 2001 From: Tom Christian Date: Wed, 1 Oct 2025 14:11:27 -0700 Subject: [PATCH] feat(#62838): PR feedback cheaper download check --- src/gui/stac/qgsstacdataitemguiprovider.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gui/stac/qgsstacdataitemguiprovider.cpp b/src/gui/stac/qgsstacdataitemguiprovider.cpp index 9fe3f9891aa..9d2224a1f58 100644 --- a/src/gui/stac/qgsstacdataitemguiprovider.cpp +++ b/src/gui/stac/qgsstacdataitemguiprovider.cpp @@ -89,16 +89,17 @@ void QgsStacDataItemGuiProvider::populateContextMenu( QgsDataItem *item, QMenu * { menu->addSeparator(); - int downloadableAssets = 0; + bool hasDownloadableAssets = false; const QMap assets = itemItem->stacItem()->assets(); for ( auto it = assets.constBegin(); it != assets.constEnd(); ++it ) { if ( it.value().isDownloadable() ) { - downloadableAssets += 1; + hasDownloadableAssets = true; + break; } } - if ( downloadableAssets > 0 ) + if ( hasDownloadableAssets ) { QAction *actionDownload = new QAction( tr( "Download Assets…" ), menu ); connect( actionDownload, &QAction::triggered, this, [itemItem, context] { downloadAssets( itemItem, context ); } );