sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-03 00:02:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix leak of network replies when network content is fetched in a thread

Browse Source 
which is destroyed soon after

Because the thread is destroyed, the event loops never executes and
deleteLater is never called, resulting the a leak of the network reply
This commit is contained in:
Nyall Dawson 2020-08-04 09:28:19 +10:00
parent 78cea71e00
commit 723e62ecd1
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/qgsnetworkcontentfetcher.cpp
View File

@ -31,10 +31,7 @@ QgsNetworkContentFetcher::~QgsNetworkContentFetcher()
//cancel running request //cancel running request
mReply->abort(); mReply->abort();
} }
if ( mReply ) delete mReply;
{
mReply->deleteLater();
}
} }
void QgsNetworkContentFetcher::fetchContent( const QUrl &url, const QString &authcfg ) void QgsNetworkContentFetcher::fetchContent( const QUrl &url, const QString &authcfg )