diff --git a/src/providers/gdal/qgsgdalprovider.cpp b/src/providers/gdal/qgsgdalprovider.cpp index 0be036c29f6..f59db6c80c2 100644 --- a/src/providers/gdal/qgsgdalprovider.cpp +++ b/src/providers/gdal/qgsgdalprovider.cpp @@ -1154,7 +1154,7 @@ QString QgsGdalProvider::generateBandName( int bandNumber ) const val = values.at( 1 ); if ( values.at( 0 ) == QLatin1String( "NETCDF_DIM_EXTRA" ) ) { - dimExtraValues = val.replace( QStringLiteral( "{" ), QString() ).replace( QStringLiteral( "}" ), QString() ).split( ',' ); + dimExtraValues = val.replace( '{', QString() ).replace( '}', QString() ).split( ',' ); //http://qt-project.org/doc/qt-4.8/qregexp.html#capturedTexts } else diff --git a/src/server/qgsserverrequest.cpp b/src/server/qgsserverrequest.cpp index c31a489e760..0eed7a003ec 100644 --- a/src/server/qgsserverrequest.cpp +++ b/src/server/qgsserverrequest.cpp @@ -81,7 +81,7 @@ QMap QgsServerRequest::parameters() const { // prepare the value QString value = pair.second; - value.replace( "+", " " ); + value.replace( '+', ' ' ); mParams.insert( pair.first.toUpper(), value ); } diff --git a/src/server/services/wfs/qgswfsgetfeature.cpp b/src/server/services/wfs/qgswfsgetfeature.cpp index 35365682705..6e059fecfea 100644 --- a/src/server/services/wfs/qgswfsgetfeature.cpp +++ b/src/server/services/wfs/qgswfsgetfeature.cpp @@ -1298,7 +1298,7 @@ namespace QgsWfs continue; } - QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( QStringLiteral( " " ), QStringLiteral( "_" ) ) ); + QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( ' ', '_' ) ); QDomText fieldText = doc.createTextNode( featureAttributes[idx].toString() ); fieldElem.appendChild( fieldText ); typeNameElement.appendChild( fieldElem ); @@ -1399,7 +1399,7 @@ namespace QgsWfs continue; } - QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( QStringLiteral( " " ), QStringLiteral( "_" ) ) ); + QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( ' ', '_' ) ); QDomText fieldText = doc.createTextNode( featureAttributes[idx].toString() ); fieldElem.appendChild( fieldText ); typeNameElement.appendChild( fieldElem ); diff --git a/src/server/services/wfs/qgswfsparameters.cpp b/src/server/services/wfs/qgswfsparameters.cpp index 22101d54c49..6de470e923c 100644 --- a/src/server/services/wfs/qgswfsparameters.cpp +++ b/src/server/services/wfs/qgswfsparameters.cpp @@ -383,7 +383,7 @@ namespace QgsWfs if ( !bbox.isEmpty() ) { - const QStringList corners = bbox.split( ',' ); + QStringList corners = bbox.split( ',' ); if ( corners.size() == 4 ) { diff --git a/src/server/services/wfs/qgswfstransaction.cpp b/src/server/services/wfs/qgswfstransaction.cpp index 6b8166ce96d..0d89215b5f6 100644 --- a/src/server/services/wfs/qgswfstransaction.cpp +++ b/src/server/services/wfs/qgswfstransaction.cpp @@ -933,7 +933,7 @@ namespace QgsWfs } // get bbox corners - const QStringList corners = bbox.split( ',' ); + QStringList corners = bbox.split( ',' ); if ( corners.size() != 4 ) { throw QgsRequestNotWellFormedException( QStringLiteral( "BBOX has to be composed of 4 elements: '%1'" ).arg( bbox ) ); diff --git a/src/server/services/wfs/qgswfstransaction_1_0_0.cpp b/src/server/services/wfs/qgswfstransaction_1_0_0.cpp index d204edf371c..f279e9820db 100644 --- a/src/server/services/wfs/qgswfstransaction_1_0_0.cpp +++ b/src/server/services/wfs/qgswfstransaction_1_0_0.cpp @@ -916,7 +916,7 @@ namespace QgsWfs } // get bbox corners - const QStringList corners = bbox.split( ',' ); + QStringList corners = bbox.split( ',' ); if ( corners.size() != 4 ) { throw QgsRequestNotWellFormedException( QStringLiteral( "BBOX has to be composed of 4 elements: '%1'" ).arg( bbox ) ); diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp index 01504320953..5cd7203b448 100644 --- a/src/server/services/wms/qgswmsrenderer.cpp +++ b/src/server/services/wms/qgswmsrenderer.cpp @@ -2224,7 +2224,7 @@ namespace QgsWms continue; } - QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( QStringLiteral( " " ), QStringLiteral( "_" ) ) ); + QDomElement fieldElem = doc.createElement( "qgs:" + attributeName.replace( ' ', '_' ) ); QString fieldTextString = featureAttributes.at( i ).toString(); if ( layer ) {