diff --git a/src/app/labeling/qgsmaptoollabel.cpp b/src/app/labeling/qgsmaptoollabel.cpp index 4d05279e09c..9ee09d49545 100644 --- a/src/app/labeling/qgsmaptoollabel.cpp +++ b/src/app/labeling/qgsmaptoollabel.cpp @@ -808,7 +808,7 @@ bool QgsMapToolLabel::createAuxiliaryFields( LabelDetails &details, QgsPalIndexe { index = vlayer->fields().lookupField( prop.field() ); } - else if ( prop.propertyType() != QgsProperty::ExpressionBasedProperty || ( prop.propertyType() == QgsProperty::ExpressionBasedProperty && overwriteExpression ) ) + else if ( prop.propertyType() != QgsProperty::ExpressionBasedProperty || overwriteExpression ) { index = QgsAuxiliaryLayer::createProperty( p, vlayer ); changed = true; @@ -860,7 +860,7 @@ bool QgsMapToolLabel::createAuxiliaryFields( LabelDetails &details, QgsDiagramIn { index = vlayer->fields().lookupField( prop.field() ); } - else if ( prop.propertyType() != QgsProperty::ExpressionBasedProperty || ( prop.propertyType() == QgsProperty::ExpressionBasedProperty && overwriteExpression ) ) + else if ( prop.propertyType() != QgsProperty::ExpressionBasedProperty || overwriteExpression ) { index = QgsAuxiliaryLayer::createProperty( p, vlayer ); changed = true; diff --git a/src/app/qgsattributetabledialog.cpp b/src/app/qgsattributetabledialog.cpp index 674ac510ab2..d4423e3f7f3 100644 --- a/src/app/qgsattributetabledialog.cpp +++ b/src/app/qgsattributetabledialog.cpp @@ -79,7 +79,7 @@ void QgsAttributeTableDialog::updateMultiEditButtonState() mActionToggleMultiEdit->setEnabled( mLayer->isEditable() ); - if ( !mLayer->isEditable() || ( mLayer->isEditable() && mMainView->view() != QgsDualView::AttributeEditor ) ) + if ( !mLayer->isEditable() || mMainView->view() != QgsDualView::AttributeEditor ) { mActionToggleMultiEdit->setChecked( false ); } diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp index cdd6e0ae796..99282d1fe89 100644 --- a/src/core/qgsvectorlayer.cpp +++ b/src/core/qgsvectorlayer.cpp @@ -787,7 +787,7 @@ QgsVectorLayerFeatureCounter *QgsVectorLayer::countSymbolFeatures( bool storeSym return mFeatureCounter; } - if ( !mFeatureCounter || ( mFeatureCounter && ( storeSymbolFids && mSymbolFeatureIdMap.isEmpty() ) ) ) + if ( !mFeatureCounter || ( storeSymbolFids && mSymbolFeatureIdMap.isEmpty() ) ) { mFeatureCounter = new QgsVectorLayerFeatureCounter( this, QgsExpressionContext(), storeSymbolFids ); connect( mFeatureCounter, &QgsTask::taskCompleted, this, &QgsVectorLayer::onFeatureCounterCompleted, Qt::UniqueConnection ); diff --git a/src/plugins/grass/qtermwidget/TerminalDisplay.cpp b/src/plugins/grass/qtermwidget/TerminalDisplay.cpp index 21e7d034988..a3766382b47 100644 --- a/src/plugins/grass/qtermwidget/TerminalDisplay.cpp +++ b/src/plugins/grass/qtermwidget/TerminalDisplay.cpp @@ -1825,7 +1825,7 @@ void TerminalDisplay::mousePressEvent( QMouseEvent *ev ) } else if ( ev->button() == Qt::MidButton ) { - if ( _mouseMarks || ( !_mouseMarks && ( ev->modifiers() & Qt::ShiftModifier ) ) ) + if ( _mouseMarks || ( ev->modifiers() & Qt::ShiftModifier ) ) emitSelection( true, ev->modifiers() & Qt::ControlModifier ); else emit mouseSignal( 1, charColumn + 1, charLine + 1 + _scrollBar->value() - _scrollBar->maximum(), 0 ); diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp index e6eec391ffe..4ae9ca9b01f 100644 --- a/src/providers/spatialite/qgsspatialiteprovider.cpp +++ b/src/providers/spatialite/qgsspatialiteprovider.cpp @@ -1015,7 +1015,7 @@ void QgsSpatiaLiteProvider::insertDefaultValue( int fieldIndex, QString defaultV { QVariant defaultVariant = defaultVal; - if ( mAttributeFields.at( fieldIndex ).name() != mPrimaryKey || ( mAttributeFields.at( fieldIndex ).name() == mPrimaryKey && !mPrimaryKeyAutoIncrement ) ) + if ( mAttributeFields.at( fieldIndex ).name() != mPrimaryKey || !mPrimaryKeyAutoIncrement ) { bool ok; switch ( mAttributeFields.at( fieldIndex ).type() )