From eb3c78d12df9e45d91df8706c6e09cadf0773149 Mon Sep 17 00:00:00 2001 From: Alessandro Pasotti Date: Fri, 25 Sep 2020 10:56:08 +0200 Subject: [PATCH] DB manager fix add comment while creating table Fixes #38394 --- python/plugins/db_manager/db_plugins/data_model.py | 2 +- python/plugins/db_manager/db_plugins/plugin.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/python/plugins/db_manager/db_plugins/data_model.py b/python/plugins/db_manager/db_plugins/data_model.py index 739b6a69104..82ddb403fdd 100644 --- a/python/plugins/db_manager/db_plugins/data_model.py +++ b/python/plugins/db_manager/db_plugins/data_model.py @@ -301,7 +301,7 @@ class TableFieldsModel(SimpleTableModel): fld.notNull = self.data(self.index(row, 2), Qt.CheckStateRole) == Qt.Unchecked fld.primaryKey = self.data(self.index(row, 1), Qt.UserRole) - fld.comment = self.data(self.index(row, 4), Qt.UserRole) + fld.comment = self.data(self.index(row, 4)) return fld def getFields(self): diff --git a/python/plugins/db_manager/db_plugins/plugin.py b/python/plugins/db_manager/db_plugins/plugin.py index 0cbad82c9eb..9cf0150f33b 100644 --- a/python/plugins/db_manager/db_plugins/plugin.py +++ b/python/plugins/db_manager/db_plugins/plugin.py @@ -585,6 +585,13 @@ class Database(DbItemObject): ret = self.connector.createTable((schema, table), field_defs, pk_name) if ret is not False: + # Add comments if any, because definition does not include + # the comment + for f in fields: + if f.comment: + self.connector.updateTableColumn( + (schema, table), f.name, comment=f.comment + ) self.refresh() return ret