sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-10-04 00:04:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix comparator for model component deletion priority

Browse Source 
Fixes #62046
This commit is contained in:
Nyall Dawson 2025-06-02 14:26:52 +10:00
parent 92c9a19691
commit 4cbb7ca3b5
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/gui/processing/models/qgsmodeldesignerdialog.cpp
View File

@ -814,23 +814,38 @@ void QgsModelDesignerDialog::deleteSelected()
std::sort( items.begin(), items.end(), []( QgsModelComponentGraphicItem *p1, QgsModelComponentGraphicItem *p2 ) {
// try to delete the easy stuff first, so comments, then outputs, as nothing will depend on these...
if ( dynamic_cast<QgsModelCommentGraphicItem *>( p1 ) )
// NOLINTBEGIN(bugprone-branch-clone)
// 1. comments
if ( dynamic_cast<QgsModelCommentGraphicItem *>( p1 ) && dynamic_cast<QgsModelCommentGraphicItem *>( p2 ) )
return false;
else if ( dynamic_cast<QgsModelCommentGraphicItem *>( p1 ) )
return true;
else if ( dynamic_cast<QgsModelCommentGraphicItem *>( p2 ) )
return false;
// 2. group boxes
else if ( dynamic_cast<QgsModelGroupBoxGraphicItem *>( p1 ) && dynamic_cast<QgsModelGroupBoxGraphicItem *>( p2 ) )
return false;
else if ( dynamic_cast<QgsModelGroupBoxGraphicItem *>( p1 ) )
return true;
else if ( dynamic_cast<QgsModelGroupBoxGraphicItem *>( p2 ) )
return false;
// 3. outputs
else if ( dynamic_cast<QgsModelOutputGraphicItem *>( p1 ) && dynamic_cast<QgsModelOutputGraphicItem *>( p2 ) )
return false;
else if ( dynamic_cast<QgsModelOutputGraphicItem *>( p1 ) )
return true;
else if ( dynamic_cast<QgsModelOutputGraphicItem *>( p2 ) )
return false;
// 4. child algorithms
else if ( dynamic_cast<QgsModelChildAlgorithmGraphicItem *>( p1 ) && dynamic_cast<QgsModelChildAlgorithmGraphicItem *>( p2 ) )
return false;
else if ( dynamic_cast<QgsModelChildAlgorithmGraphicItem *>( p1 ) )
return true;
else if ( dynamic_cast<QgsModelChildAlgorithmGraphicItem *>( p2 ) )
return false;
return false;
// NOLINTEND(bugprone-branch-clone)
} );