sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-23 00:05:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed redundant check for isValid

Browse Source
This commit is contained in:
Alessandro Pasotti 2019-02-20 10:29:01 +01:00
parent 2604fc70c5
commit 4250ef249a
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/qgsvectorlayerutils.cpp
View File

@ -494,8 +494,8 @@ QgsFeatureList QgsVectorLayerUtils::createFeatures( const QgsVectorLayer *layer,
// 2. client side default expression // 2. client side default expression
// note - deliberately not using else if! // note - deliberately not using else if!
if ( ( ! v.isValid() || v.isNull() || ( hasUniqueConstraint if ( ( v.isNull() || ( hasUniqueConstraint
&& uniqueValueCaches[ idx ].contains( v ) ) ) && uniqueValueCaches[ idx ].contains( v ) ) )
&& layer->defaultValueDefinition( idx ).isValid() ) && layer->defaultValueDefinition( idx ).isValid() )
{ {
// client side default expression set - takes precedence over all. Why? Well, this is the only default // client side default expression set - takes precedence over all. Why? Well, this is the only default
@ -506,8 +506,8 @@ QgsFeatureList QgsVectorLayerUtils::createFeatures( const QgsVectorLayer *layer,
// 3. provider side default value clause // 3. provider side default value clause
// note - not an else if deliberately. Users may return null from a default value expression to fallback to provider defaults // note - not an else if deliberately. Users may return null from a default value expression to fallback to provider defaults
if ( ( ! v.isValid() || v.isNull() || ( hasUniqueConstraint if ( ( v.isNull() || ( hasUniqueConstraint
&& uniqueValueCaches[ idx ].contains( v ) ) ) && uniqueValueCaches[ idx ].contains( v ) ) )
&& fields.fieldOrigin( idx ) == QgsFields::OriginProvider ) && fields.fieldOrigin( idx ) == QgsFields::OriginProvider )
{ {
int providerIndex = fields.fieldOriginIndex( idx ); int providerIndex = fields.fieldOriginIndex( idx );
@ -521,8 +521,8 @@ QgsFeatureList QgsVectorLayerUtils::createFeatures( const QgsVectorLayer *layer,
// 4. provider side default literal // 4. provider side default literal
// note - deliberately not using else if! // note - deliberately not using else if!
if ( ( ! v.isValid() || v.isNull() || ( checkUnique && hasUniqueConstraint if ( ( v.isNull() || ( checkUnique && hasUniqueConstraint
&& uniqueValueCaches[ idx ].contains( v ) ) ) && uniqueValueCaches[ idx ].contains( v ) ) )
&& fields.fieldOrigin( idx ) == QgsFields::OriginProvider ) && fields.fieldOrigin( idx ) == QgsFields::OriginProvider )
{ {
int providerIndex = fields.fieldOriginIndex( idx ); int providerIndex = fields.fieldOriginIndex( idx );
@ -536,7 +536,7 @@ QgsFeatureList QgsVectorLayerUtils::createFeatures( const QgsVectorLayer *layer,
// 5. passed attribute value // 5. passed attribute value
// note - deliberately not using else if! // note - deliberately not using else if!
if ( ( !v.isValid() || v.isNull() ) && fd.attributes().contains( idx ) ) if ( v.isNull() && fd.attributes().contains( idx ) )
{ {
v = fd.attributes().value( idx ); v = fd.attributes().value( idx );
} }