sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-10-05 00:09:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Yoann Quenach de Quivillic 2023-03-21 11:09:30 +01:00 committed by Nyall Dawson
parent 9d3140c55a
commit 33863ceace
4 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
python/core/auto_generated/qgsbookmarkmanager.sip.in
View File

@ -97,6 +97,8 @@ Sets the bookmark's spatial ``extent``.
Returns the bookmark's map rotation.
.. seealso:: :py:func:`setRotation`
.. versionadded:: 3.32
%End
void setRotation( double rotation );
@ -104,6 +106,8 @@ Returns the bookmark's map rotation.
Sets the bookmark's spatial map ``rotation``.
.. seealso:: :py:func:`rotation`
.. versionadded:: 3.32
%End
static QgsBookmark fromXml( const QDomElement &element, const QDomDocument &doc );

4
src/core/qgsbookmarkmanager.h
View File

@ -100,12 +100,16 @@ class CORE_EXPORT QgsBookmark
/**
* Returns the bookmark's map rotation.
* \see setRotation()
*
* \since QGIS 3.32
*/
double rotation() const;
/**
* Sets the bookmark's spatial map \a rotation.
* \see rotation()
*
* \since QGIS 3.32
*/
void setRotation( double rotation );

2
src/core/qgsbookmarkmodel.cpp
View File

@ -276,7 +276,7 @@ QVariant QgsBookmarkManagerModel::headerData( int section, Qt::Orientation orien
case ColumnYMax:
return tr( "yMax" );
case ColumnRotation:
return tr( "rotation" );
return tr( "Rotation" );
case ColumnCrs:
return tr( "CRS" );
case ColumnStore:

10
src/ui/qgsbookmarkeditordialog.ui
View File

@ -82,7 +82,7 @@
</widget>
</item>
<item row="3" column="1">
<widget class="QDoubleSpinBox" name="mRotation">
<widget class="QgsDoubleSpinBox" name="mRotation">
<property name="suffix">
<string> °</string>
</property>
@ -95,6 +95,9 @@
<property name="maximum">
<double>360.000000000000000</double>
</property>
<property name="clearValue" stdset="0">
<double>0.000000000000000</double>
</property>
</widget>
</item>
</layout>
@ -137,6 +140,11 @@
<header>qgsextentgroupbox.h</header>
<container>1</container>
</customwidget>
<customwidget>
<class>QgsDoubleSpinBox</class>
<extends>QDoubleSpinBox</extends>
<header>qgsdoublespinbox.h</header>
</customwidget>
</customwidgets>
<tabstops>
<tabstop>mName</tabstop>